Demonstrate SignalR JS header option#20247
Merged
Conversation
halter73
force-pushed
the
halter73/js-options
branch
from
e5d8b3c to
0a7b6cf
Compare
halter73
changed the title
BrennanConroy
approved these changes
Oct 20, 2020
halter73
commented
Oct 20, 2020
halter73
commented
Oct 20, 2020
halter73
force-pushed
the
halter73/js-options
branch
from
f772f44 to
621350b
Compare
guardrex
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added
transportto the JS options table for consistency considering we also do that for theaccessTokenFactorydespite already demonstrating how to use it in an above section. I almost did the same forloggerbut decided against it consideringconfigureLogging()is the right way to configure thelogger.@BrennanConroy