React to 10.0 samp updates for MAUI BH+Web App+Identity#36944
Merged
Conversation
Collaborator
Author
|
@wadepickett ... This is also reviewable by our team. See the OP for the NIT changes here. |
wadepickett
approved these changes
Apr 3, 2026
Contributor
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Great work! Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36221
Matt ... Good news! Only minimal updates required. The app runs fine, and the registration page was there after all. All I can figure that went wrong was that I didn't start from the
.Webproject after setting the MAUI project as the startup project ... i.e., I didn't follow the article's instructions correctly. 🙈😄 Sorry for the trouble on that.WRT the changes that I'd like to make ...
LoginWithProviderAsyncmethod and let the reader look in the sample app because that code has minor changes across the two sample versions (e.g., the Remember Me feature is in the 10.0 samp but not the 9.0 samp). The text just needs to state which file to look at where it's discussed.If you approve the changes, I'll publish these updates. We require one approval to get any PR merged.
Internal previews