Skip to content

chore: Add retry and increase timeout for dotMemory/dotTrace tests#2971

Merged
timcassell merged 3 commits intodotnet:masterfrom
filzrev:chore-add-flakytests-retry-and-increase-timeout
Jan 18, 2026
Merged

chore: Add retry and increase timeout for dotMemory/dotTrace tests#2971
timcassell merged 3 commits intodotnet:masterfrom
filzrev:chore-add-flakytests-retry-and-increase-timeout

Conversation

@filzrev
Copy link
Copy Markdown
Contributor

@filzrev filzrev commented Jan 16, 2026

This PR intended to fix a part of issue #2950.

What's changed in this PR

  1. Increase attach to external process timeout from 30 seconds to 60 seconds.
  2. Add retry logics for InitTool() that download/install prerequisite tools.
  3. Replace Wait() to GetAwaiter().GetResult() to avoid AggregateException is thrown.

Comment thread src/BenchmarkDotNet.Diagnostics.dotMemory/DotMemoryDiagnoser.cs Outdated
Comment thread src/BenchmarkDotNet.Diagnostics.dotTrace/DotTraceDiagnoser.cs Outdated
@timcassell timcassell merged commit 6128fd6 into dotnet:master Jan 18, 2026
1 check passed
@timcassell timcassell added this to the v0.16.0 milestone Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants