Skip to content

chore: Add ThreadingDiagnoserTests with InProcessToolchain#3090

Merged
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-enable-inprocess-threding-diagnoser-tests
Apr 19, 2026
Merged

chore: Add ThreadingDiagnoserTests with InProcessToolchain#3090
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-enable-inprocess-threding-diagnoser-tests

Conversation

@filzrev
Copy link
Copy Markdown
Contributor

@filzrev filzrev commented Apr 18, 2026

Currently, ThreadingDiagnoserTests with InProcessEmitToolchain is commented out with following commit.
852bb8c

This PR enable these tests that use InProcessToolin.
Because it seems works without problem on latest codebase (As far as I've tested)

By this changes, it can implement skip long-running tests on Draft PR (#3088) (Currently, it takes about 4 minutes)

@timcassell timcassell merged commit 02badb4 into dotnet:master Apr 19, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Apr 19, 2026
@filzrev
Copy link
Copy Markdown
Contributor Author

filzrev commented Apr 20, 2026

On latest master CI.
CompletedWorkItemCountIsAccurate test failed on macos(arm64) with following error.

Error message

CompletedWorkItemCountIsAccurate(toolchain: InProcessEmitToolchain) [FAIL]
       Assert.Equal() Failure: Values are not within 2 decimal places
       Expected: 1 (rounded from 1)
       Actual:   1.02 (rounded from 1.015625)

The following actions are required to fix this issue.

  1. Revert this PR commit
  2. Reduce precision when comparing metrics value (Because original CompletedWorkItemCount/LockContentionCount value is integer)
    Assert.Equal(assertion.Value.expectedValue, metric.Value.Value, precision: 2);
    .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants