fix: StaticFieldsAndPropertiesCanBeParams+InProcessEmitToolchain test issue#3119
Merged
Conversation
timcassell
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #3118
What's changed in this PR
Add
BindingFlags.FlattenHierarchyto reflection logics onRunnableReflectionHelpers.SetParameter.Currently, it failed to resolve inherited static property/field on following lines.
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/InProcess/Emit/Implementation/Runnable/RunnableReflectionHelpers.cs
Lines 79 to 86 in 4cb0703
By this change, It can resolve inherited static property/field.
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.bindingflags?view=net-8.0#fields
Test
Currently, test behavior is confirmed local environment.
I'll modify
ParamsTeststo useInProcessToolchainon another PR (Reduce CI execution time).