chore: Fix regression of PowershellWmiCpuDetector#3127
Merged
timcassell merged 1 commit intoMay 12, 2026
Merged
Conversation
filzrev
changed the title
timcassell
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix regression that introduced by #3122
That PR merge of Wmic/Cim command output parse logics.
But these changes are wrong and it cause
Unknown processoronwmic.exeis not installed environment.What's changed in this PR
1.
CpuInfoParser.csWmiCpuInfoParsertoCpuInfoParserParseCoreParseCimOutput/ParseWmicOutputand rename caller method names.2.
PowershellWmiCpuDetectorFormat-List {argList}to filter properties and ensure output is list format3.
CpuInfoParserTests_Cim.cs/CpuInfoParserTests_Wmic.csPowershellWmiCpuInfoParserTests.cstest contents and rename file.