Conversation
Avoid accessing ReadResult.Buffer after PipeReader.AdvanceTo
This is consistent with PipeReader.AdvanceTo behavior.
Fix the `PipeReader` returned from `Stream.UseStrictPipeReader` to throw if `ReadAsync(CancellationToken)` or `TryRead(out ReadResult)` is called after a prior call to either of these methods without an `AdvanceTo` method call happening in between them. This makes our `PipeReader` behave the same as the one from .NET's own `Pipe` class.
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 90.91% 90.35% -0.57%
==========================================
Files 34 34
Lines 2433 2447 +14
==========================================
- Hits 2212 2211 -1
- Misses 221 236 +15
Continue to review full report at Codecov.
|
AArnott
added a commit
that referenced
this pull request
Jun 7, 2022
Fix several Install-DotNetSdk issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153