East Asia is better term #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@davidchesnut You created the PR against master which was quite far behind vNext (the current dev branch). We are, however, in the process of moving to committing directly to master, so master is now up to date. However, your change must be updated before it can be merged. |
Contributor
Author
|
I'll resubmit on the vNext branch. |
Member
|
@davidchesnut You actually submitted as I was switching our branching strategy. The vNext branch is no more. You can reopen this one and submit against master. |
Member
|
Thanks! LGTM. We'll have to update the generator for this as well, but this will fix it for now. |
twsouthwick
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.