Skip to content

Pin Build.Tasks.Core package version, add es-metadata.yml #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Pin Build.Tasks.Core package version, add es-metadata.yml #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<PackageVersion Include="Microsoft.Build.Locator" Version="$(MicrosoftBuildLocatorPackageVersion)" />
<PackageVersion Include="Microsoft.Build" Version="$(MicrosoftBuildPackageVersion)" />
<PackageVersion Include="Microsoft.Build.Runtime" Version="$(MicrosoftBuildRuntimePackageVersion)" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCorePackageVersion)" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCorePackageVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Razor.Language" Version="$(MicrosoftAspNetCoreRazorLanguagePackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="$(MicrosoftCodeAnalysisVersion)" />
Expand Down
3 changes: 2 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
<!-- Microsoft.AspNetCore.Razor.Language -->
<MicrosoftAspNetCoreRazorLanguagePackageVersion>6.0.24</MicrosoftAspNetCoreRazorLanguagePackageVersion>
<!-- Microsoft.Build-->
<MicrosoftBuildPackageVersion>17.11.4 </MicrosoftBuildPackageVersion>
<MicrosoftBuildPackageVersion>17.11.31</MicrosoftBuildPackageVersion>
<MicrosoftBuildTasksCorePackageVersion>17.14.8</MicrosoftBuildTasksCorePackageVersion>
<!-- Microsoft.Build.Utilities-->
<MicrosoftBuildUtilitiesCorePackageVersion>17.14.8</MicrosoftBuildUtilitiesCorePackageVersion>
<MicrosoftBuildLocatorPackageVersion>1.9.1</MicrosoftBuildLocatorPackageVersion>
Expand Down
8 changes: 8 additions & 0 deletions es-metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
schemaVersion: 0.0.1
isProduction: true
accountableOwners:
Copy link
Member

@haileymck haileymck Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file for? maybe add a comment here

Copy link
Member Author

@phenning phenning Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the standard 1es inventory file that is being moved to in places of the service catalog. if you look in other repos, including WebTools, you’ll see similar there. I just took what got generated by the automated PR and used it here.

service: 225159cd-5cda-4eaf-9b48-9bc4ff385b23
routing:
defaultAreaPath:
org: devdiv
path: DevDiv\NET Tools\Web Tools\Web\Scaffolding
2 changes: 2 additions & 0 deletions src/dotnet-scaffolding/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
<PackageVersion Include="Microsoft.ApplicationInsights.WorkerService" Version="$(MicrosoftApplicationInsightsWorkerServicePackageVersion)" />
<PackageVersion Include="Microsoft.Build.Locator" Version="$(MicrosoftBuildLocatorPackageVersion)" />
<PackageVersion Include="Microsoft.Build" Version="$(MicrosoftBuildPackageVersion)" />
<!-- pinning this directly here, as this version needs to be different -->
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.11.31" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="$(MicrosoftCodeAnalysisPreviewVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisPreviewVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Features" Version="$(MicrosoftCodeAnalysisPreviewVersion)" />
Expand Down
1 change: 1 addition & 0 deletions ...caffolding/Microsoft.DotNet.Scaffolding.Roslyn/Microsoft.DotNet.Scaffolding.Roslyn.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Build.Locator" />
<PackageReference Include="Microsoft.Build" ExcludeAssets="runtime" />
<PackageReference Include="Microsoft.Build.Tasks.Core" ExcludeAssets="runtime" />
<PackageReference Include="Microsoft.CodeAnalysis.Common" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Features" />
Expand Down
1 change: 1 addition & 0 deletions test/Scaffolding/VS.Web.CG.MSBuild.Test/VS.Web.CG.MSBuild.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Build.Runtime" />
<PackageReference Include="Microsoft.Build.Tasks.Core" />
<PackageReference Include="Microsoft.Extensions.FileProviders.Physical" />
<PackageReference Include="NuGet.Packaging" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions test/Scaffolding/VS.Web.CG.Sources.Test/VS.Web.CG.Sources.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Build.Runtime" />
<PackageReference Include="Microsoft.Build.Tasks.Core" />
<PackageReference Include="Microsoft.Extensions.FileProviders.Physical" />
</ItemGroup>

Expand Down