Skip to content

Add forced resigning of SDL2 outputs after stripping #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2024
Merged

Add forced resigning of SDL2 outputs after stripping #2174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce05e93
Add forced resigning of SDL2 outputs after stripping
joskuijpers May 10, 2024
53b7d09
Prevent warnings, as we know what we're doing
joskuijpers May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build/nuke/Native/SDL2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ static readonly (string Sdk, string Arch, string Rid, string Args)[] iPhoneConfi

EnsureCleanDirectory(Path.GetDirectoryName(@out));
InheritedShell($"lipo -create -output \"{@out}\" \"{@in}\"").AssertZeroExitCode();
InheritedShell($"strip -Sx \"{@out}\"").AssertZeroExitCode();
InheritedShell($"strip -Sx -no_code_signature_warning \"{@out}\"").AssertZeroExitCode();

// Re-sign, as lipo and stripping invalidates the signature
InheritedShell($"codesign --remove-signature \"{@out}\"").AssertZeroExitCode();
InheritedShell($"codesign --sign - \"{@out}\"").AssertZeroExitCode();
}
}

Expand Down