Fix SilkMarshal.PtrToStringArray ignores the encoding parameter #2376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exanite
changed the title
Contributor
Author
|
@dotnet-policy-service agree |
Perksey
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This fixes #2375 by making SilkMarshal.PtrToStringArray respect the encoding parameter that is passed in.
Related issues, Discord discussions, or proposals
#2375
Further Comments
This also adds Silk.NET.Core.Tests, a new test project for Silk.NET.Core.
This part will be used more in my next pull request, #2377, which depends on this one.