[3.0] Fix OpenAL loading on Windows and make the examples run out-of-the-box#2573
Draft
Exanite wants to merge 45 commits intodevelop/3.0from
Draft
[3.0] Fix OpenAL loading on Windows and make the examples run out-of-the-box#2573Exanite wants to merge 45 commits intodevelop/3.0from
Exanite wants to merge 45 commits intodevelop/3.0from
Conversation
(cherry picked from commit 7938a0c)
(cherry picked from commit e4f8325)
(cherry picked from commit b0db2ba)
(cherry picked from commit 156aa5c)
armv7s seems to be legacy. (cherry picked from commit 25b0e27)
CMAKE_LIBRARY_ARCHITECTURE fixes the issue where system libraries weren't being found. Eg: "SDL_X11 (Wanted: ON): ON" was OFF without this setting. Eg: "Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so " was a not found error without this setting. I removed the pkg-config settings since they didn't seem to do anything and I couldn't figure out if they were correct in the first place. I'm assuming CMake figures these out automatically (it should automatically find the host version of the pkg-config executable and I'm *assuming* (please verify) it uses the CMAKE_LIBRARY_ARCHITECTURE variable to figure out which set of .pc files to use).
x64/amd64 is handled the same way for consistency.
…x package resolution issues
This is because it otherwise gets confusing in the "run project" dropdown.
(cherry picked from commit ecc5677)
…e, but dependencies first by default is most consistent) (cherry picked from commit ad2d940)
…'s native build process
apt-get seems to be recommended over apt for scripting purposes. apt is designed for humans and does not guarantee backwards compatibility. See https://manpages.debian.org/stretch/apt/apt.8.en.html
Contributor
|
Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains |
12 tasks
Contributor
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against bb59721 |
Member
Author
|
Looks like the license identifier is invalid and causing the pack step of the build to fail: Also, it looks like the correct identifier should be |
curin
approved these changes
May 1, 2026
github-project-automation
Bot
moved this from Todo
to In Progress
in Silk.NET Development Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This will fix #2572
Related issues, Discord discussions, or proposals
Discord discussion: https://discord.com/channels/521092042781229087/587346162802229298/1499401418896048238
Further Comments
Should wait until #2570 is merged before merging this one.