[2.x] Split Build workflow into two#2585
Closed
Exanite wants to merge 7 commits into
Closed
Conversation
Notably, this is where the `nuke --plan` html file output is stored.
Member
Author
|
So splitting the workflows saves about 15 minutes compared to not splitting them. Not fully convinced this is worth doing since it's still long enough that it is easier to leave running and come back later. We can automerge anyway so we can just hit automerge and walk away once a PR is acceptable for merging. The main downside is iterating on contributions, but technically, we can see the results of the check while it is running so it's the difference between seeing a green checkmark vs clicking into the workflow to see what step it is on. This does make it is less contributor friendly, but I'd rather just have a working system (if slow) for Silk 2.x and focus on Silk 3.0 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This is an alternative of #2580, which explains the primary motivation for modifying the build system (in summary, branch protection rules need checks to run so we can't simply exclude them from being ran to save on time).
#2580 does this by just making the Build workflow always run, thus satisfying the branch protection requirement.
However, the workflow takes 1 hour to complete.
This workflow tries a different approach by splitting the Build workflow into two:
Related issues, Discord discussions, or proposals
Related PR (also linked above): #2580
Further Comments
Merging this PR will require the branch protection rules to require the
Checkworkflow instead of theBuildworkflow. Currently the rules requireBuild.