Skip to content

Remove json dependency for net9#3767

Merged
apoorvdeshmukh merged 3 commits into
release/6.0from
dev/ad/update-nuspec
Nov 14, 2025
Merged

Remove json dependency for net9#3767
apoorvdeshmukh merged 3 commits into
release/6.0from
dev/ad/update-nuspec

Conversation

@apoorvdeshmukh
Copy link
Copy Markdown
Contributor

@apoorvdeshmukh apoorvdeshmukh commented Nov 14, 2025

Description

Remove incorrect dependency System.Text.Json from nuspec file for .NET9

Keeping the nuspec aligned with this output

\git\SqlClient>dotnet list src\Microsoft.Data.SqlClient\netcore\src package
Project 'Microsoft.Data.SqlClient' has the following package references
   [net8.0]:
   Top-level Package                                         Requested    Resolved
   > Azure.Identity                                          1.14.2       1.14.2
   > Microsoft.Bcl.Cryptography                              8.0.0        8.0.0
   > Microsoft.Data.SqlClient.SNI.runtime                    6.0.2        6.0.2
   > Microsoft.Extensions.Caching.Memory                     8.0.1        8.0.1
   > Microsoft.IdentityModel.JsonWebTokens                   7.5.0        7.5.0
   > Microsoft.IdentityModel.Protocols.OpenIdConnect         7.5.0        7.5.0
   > Microsoft.NET.ILLink.Tasks                        (A)   [8.0.22, )   8.0.22
   > Microsoft.SqlServer.Server                              1.0.0        1.0.0
   > System.Configuration.ConfigurationManager               8.0.1        8.0.1
   > System.Security.Cryptography.Pkcs                       8.0.1        8.0.1

   [net9.0]:
   Top-level Package                                         Requested    Resolved
   > Azure.Identity                                          1.14.2       1.14.2
   > Microsoft.Bcl.Cryptography                              9.0.4        9.0.4
   > Microsoft.Data.SqlClient.SNI.runtime                    6.0.2        6.0.2
   > Microsoft.Extensions.Caching.Memory                     9.0.4        9.0.4
   > Microsoft.IdentityModel.JsonWebTokens                   7.5.0        7.5.0
   > Microsoft.IdentityModel.Protocols.OpenIdConnect         7.5.0        7.5.0
   > Microsoft.NET.ILLink.Tasks                        (A)   [9.0.11, )   9.0.11
   > Microsoft.SqlServer.Server                              1.0.0        1.0.0
   > System.Configuration.ConfigurationManager               9.0.4        9.0.4
   > System.Security.Cryptography.Pkcs                       9.0.4        9.0.4

(A) : Auto-referenced package.

\git\SqlClient>dotnet list src\Microsoft.Data.SqlClient\netcore\ref package
Project 'Microsoft.Data.SqlClient' has the following package references
   [net8.0]:
   Top-level Package                                      Requested   Resolved
   > Azure.Identity                                       1.14.2      1.14.2
   > Microsoft.Bcl.Cryptography                           8.0.0       8.0.0
   > Microsoft.Data.SqlClient.SNI.runtime                 6.0.2       6.0.2
   > Microsoft.Extensions.Caching.Memory                  8.0.1       8.0.1
   > Microsoft.IdentityModel.JsonWebTokens                7.5.0       7.5.0
   > Microsoft.IdentityModel.Protocols.OpenIdConnect      7.5.0       7.5.0
   > Microsoft.SqlServer.Server                           1.0.0       1.0.0
   > System.Configuration.ConfigurationManager            8.0.1       8.0.1
   > System.Security.Cryptography.Pkcs                    8.0.1       8.0.1

   [net9.0]:
   Top-level Package                                      Requested   Resolved
   > Azure.Identity                                       1.14.2      1.14.2
   > Microsoft.Bcl.Cryptography                           9.0.4       9.0.4
   > Microsoft.Data.SqlClient.SNI.runtime                 6.0.2       6.0.2
   > Microsoft.Extensions.Caching.Memory                  9.0.4       9.0.4
   > Microsoft.IdentityModel.JsonWebTokens                7.5.0       7.5.0
   > Microsoft.IdentityModel.Protocols.OpenIdConnect      7.5.0       7.5.0
   > Microsoft.SqlServer.Server                           1.0.0       1.0.0
   > System.Configuration.ConfigurationManager            9.0.4       9.0.4
   > System.Security.Cryptography.Pkcs                    9.0.4       9.0.4

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an incorrect dependency on System.Text.Json from the .NET 9.0 dependency group in the NuGet package specification file.

  • Aligns .NET 9 dependencies with .NET 8, which already had this dependency removed in PR #2930
  • Removes unnecessary dependency since System.Text.Json is part of the .NET shared framework for .NET 8+ and doesn't need to be explicitly referenced

@apoorvdeshmukh apoorvdeshmukh requested a review from a team November 14, 2025 15:08
Comment thread tools/specs/Microsoft.Data.SqlClient.nuspec
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.78%. Comparing base (1542afd) to head (bcf227f).
⚠️ Report is 1 commits behind head on release/6.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.0    #3767      +/-   ##
===============================================
+ Coverage        75.51%   75.78%   +0.26%     
===============================================
  Files              244      244              
  Lines            40212    40221       +9     
===============================================
+ Hits             30368    30482     +114     
+ Misses            9844     9739     -105     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.65% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apoorvdeshmukh apoorvdeshmukh merged commit 58d0542 into release/6.0 Nov 14, 2025
102 of 239 checks passed
@apoorvdeshmukh apoorvdeshmukh deleted the dev/ad/update-nuspec branch November 14, 2025 18:46
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Nov 14, 2025
@mdaigle mdaigle added this to the 6.0.4 milestone Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants