Skip to content

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Nov 21, 2025

Description

The code coverage jobs are running out of disk space. They appear to consume upwards of 12GB of space to merge/convert 3GB of coverage logs from the various test jobs. We can diagnose why that is later. For now, I have:

  • Switched the coverage job to use the ADO-MMS22-CodeCov 1ES image rather than a generic Azure Pipelines image.
    • The generic images have 14GB of disk space.
    • Our custom 1ES image has much more space.
  • Removed unnecessary parameters/variables for code coverage job.
  • Added debug output to help see disk usage throughout the job.

Successful coverage job run: https://sqlclientdrivers.visualstudio.com/public/SqlDevX%20(public)/_build/results?buildId=131331&view=logs&s=78db0df0-7afe-532d-b7fe-bdf808bbfe01

Copilot AI review requested due to automatic review settings November 21, 2025 16:10
Copilot finished reviewing on behalf of paulmedynski November 21, 2025 16:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This draft PR addresses disk space issues in the code coverage CI job by refactoring how coverage artifacts are processed and by adding diagnostic output to track disk usage throughout the pipeline execution.

Key Changes:

  • Simplified the code coverage job parameters by moving artifact download logic into the template itself
  • Consolidated tool installations to occur at the beginning of the job as global tools instead of local installations
  • Added disk usage monitoring steps (Get-Volume) at strategic points to diagnose space consumption
  • Removed temporary files after each processing step to free up disk space

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/pipelines/dotnet-sqlclient-ci-core.yml Removed unused defaultHostedPoolName variable and simplified code coverage job invocation by replacing the complex downloadArtifactsSteps parameter with a simple targetFrameworks array
eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml Major refactoring: moved artifact downloads into the template, installed dotnet tools as global tools instead of local, added debug disk monitoring steps, improved cleanup by removing intermediate files after processing, and enhanced documentation with detailed comments

- Added SilentlyContinue to Remove-Item calls.
Copilot AI review requested due to automatic review settings November 24, 2025 16:28
Copilot finished reviewing on behalf of paulmedynski November 24, 2025 16:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.61%. Comparing base (995df25) to head (4094f55).
⚠️ Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (995df25) and HEAD (4094f55). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (995df25) HEAD (4094f55)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3798      +/-   ##
==========================================
- Coverage   76.61%   69.61%   -7.01%     
==========================================
  Files         274      268       -6     
  Lines       43393    66624   +23231     
==========================================
+ Hits        33247    46381   +13134     
- Misses      10146    20243   +10097     
Flag Coverage Δ
addons ?
netcore 69.67% <ø> (-7.01%) ⬇️
netfx 69.02% <ø> (-7.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski marked this pull request as ready for review November 25, 2025 14:02
@paulmedynski paulmedynski requested a review from a team as a code owner November 25, 2025 14:02
Copilot AI review requested due to automatic review settings November 25, 2025 14:02
@paulmedynski paulmedynski changed the title [DRAFT] Fix code coverage job disk full Fix code coverage job disk full Nov 25, 2025
Copilot finished reviewing on behalf of paulmedynski November 25, 2025 14:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor Author

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commentary for reviewers.

…pelines windows-2022 to see if that has more disk space.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@cheenamalhotra
Copy link
Member

Do you have a successful run with this PR? Link in description if possible.

@priyankatiwari08 priyankatiwari08 self-assigned this Nov 28, 2025
@paulmedynski paulmedynski merged commit 4dc47c9 into main Nov 28, 2025
251 checks passed
@paulmedynski paulmedynski deleted the dev/paul/code-coverage branch November 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants