-
Notifications
You must be signed in to change notification settings - Fork 316
Fix code coverage job disk full #3798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added debug output to help see disk usage throughout the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This draft PR addresses disk space issues in the code coverage CI job by refactoring how coverage artifacts are processed and by adding diagnostic output to track disk usage throughout the pipeline execution.
Key Changes:
- Simplified the code coverage job parameters by moving artifact download logic into the template itself
- Consolidated tool installations to occur at the beginning of the job as global tools instead of local installations
- Added disk usage monitoring steps (
Get-Volume) at strategic points to diagnose space consumption - Removed temporary files after each processing step to free up disk space
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Removed unused defaultHostedPoolName variable and simplified code coverage job invocation by replacing the complex downloadArtifactsSteps parameter with a simple targetFrameworks array |
| eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml | Major refactoring: moved artifact downloads into the template, installed dotnet tools as global tools instead of local, added debug disk monitoring steps, improved cleanup by removing intermediate files after processing, and enhanced documentation with detailed comments |
- Added SilentlyContinue to Remove-Item calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
==========================================
- Coverage 76.61% 69.61% -7.01%
==========================================
Files 274 268 -6
Lines 43393 66624 +23231
==========================================
+ Hits 33247 46381 +13134
- Misses 10146 20243 +10097
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
paulmedynski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commentary for reviewers.
…pelines windows-2022 to see if that has more disk space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Do you have a successful run with this PR? Link in description if possible. |
Description
The code coverage jobs are running out of disk space. They appear to consume upwards of 12GB of space to merge/convert 3GB of coverage logs from the various test jobs. We can diagnose why that is later. For now, I have:
Successful coverage job run: https://sqlclientdrivers.visualstudio.com/public/SqlDevX%20(public)/_build/results?buildId=131331&view=logs&s=78db0df0-7afe-532d-b7fe-bdf808bbfe01