Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Description

Our official builds perform a validation phase that executes a series of PowerShell scripts to cross-check a variety of different properties of the build artifacts. A few of these scripts use hardcoded indices into the XML structure of the csproj/props files, which is terribly fragile. This PR aligns one of these hardcoded indices with the actual props file.

Testing

A manual run of the official pipeline will confirm the fix.

Copilot AI review requested due to automatic review settings January 12, 2026 20:01
@paulmedynski paulmedynski requested a review from a team as a code owner January 12, 2026 20:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in the build validation pipeline where a hardcoded XML index was incorrectly referencing the wrong PropertyGroup in the Versions.props file. The script was using Count-1 to access the last PropertyGroup (index 8), when it should have been accessing index 2 where the TestMicrosoftDataSqlClientVersion property is actually defined.

Changes:

  • Changed hardcoded index from PropertyGroup.Count-1 to PropertyGroup[2] to correctly target the AKV NuGet Package Version Information PropertyGroup
  • Removed redundant comments that added no value

@paulmedynski paulmedynski changed the title Update hardcoded index for TestMicrosoftDataSqlClientVersion property during validation [5.1] Update hardcoded index for TestMicrosoftDataSqlClientVersion property during validation Jan 12, 2026
@paulmedynski paulmedynski added this to the 5.1.9 milestone Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.35%. Comparing base (d3aea3e) to head (a558a03).
⚠️ Report is 1 commits behind head on release/5.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.1    #3883      +/-   ##
===============================================
- Coverage        71.15%   70.35%   -0.80%     
===============================================
  Files              293      293              
  Lines            61931    61931              
===============================================
- Hits             44066    43572     -494     
- Misses           17865    18359     +494     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.37% <ø> (-0.12%) ⬇️
netfx 68.74% <ø> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit 96dff82 into release/5.1 Jan 12, 2026
84 checks passed
@paulmedynski paulmedynski deleted the dev/paul/release/5.1/validation branch January 12, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants