Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes broken MDS Official pipeline issues introduced by recent Azure Split changes. The main focus is simplifying variable management and correcting property names in the build configuration.
Changes:
- Consolidated pipeline variable definitions by removing
mds-variables.ymland moving "Release Variables" group directly into consuming files - Simplified MDS package version variables to use direct values instead of computed expressions with Major/Minor/Patch/Preview/Revision components
- Fixed build property name from
MdsAssemblyFileVersiontoAssemblyFileVersionto match the actual property used in the build system - Renamed
packageFolderNamevariable tomdsArtifactNamefor clarity - Hardcoded build configuration to
Releasefor official builds instead of using a variable - Removed unused ASSEMBLY_VERSION variable extraction step
- Added .NET SDK installation step to build job for consistency
- Cleaned up trailing whitespace throughout multiple pipeline files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/libraries/mds-variables.yml | Deleted file - its single variable group declaration moved to consuming files |
| eng/pipelines/libraries/mds-validation-variables.yml | Added Release Variables group, removed reference to deleted mds-variables.yml, cleaned trailing whitespace |
| eng/pipelines/libraries/common-variables.yml | Simplified version variable definitions from computed expressions to direct values, improved comments, cleaned trailing whitespace |
| eng/pipelines/libraries/build-variables.yml | Added Release Variables group, removed reference to deleted mds-variables.yml |
| eng/pipelines/dotnet-sqlclient-signing-pipeline.yml | Renamed packageFolderName to mdsArtifactName, cleaned trailing whitespace |
| eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml | Fixed property name from MdsAssemblyFileVersion to AssemblyFileVersion |
| eng/pipelines/common/templates/jobs/validate-signed-package-job.yml | Removed unused ASSEMBLY_VERSION variable extraction, cleaned trailing whitespace |
| eng/pipelines/common/templates/jobs/build-signed-package-job.yml | Added .NET SDK installation step, hardcoded configuration to Release, cleaned trailing whitespace |
eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
==========================================
- Coverage 74.89% 67.47% -7.43%
==========================================
Files 269 263 -6
Lines 43274 66290 +23016
==========================================
+ Hits 32410 44728 +12318
- Misses 10864 21562 +10698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The recent Azure Split PRs have broken the MDS Official pipelines in our ADO.Net project. This PR fixes a few errors and makes some select tweaks to simplify that pipeline a bit.
Testing
The Official pipeline has already been run against these changes and is working. There should be no effect to other pipelines, but normal PR/CI runs will confirm.