Introduce Logging package and rework official pipelines by cheenamalhotra · Pull Request #3967 · dotnet/SqlClient

cheenamalhotra · 2026-02-19T18:17:25Z

Summary

Moves the ETW SqlClientEventSource tracing infrastructure (~1,180 lines) from the core driver into a new Microsoft.Data.SqlClient.Extensions.Logging (netstandard2.0) NuGet package. This enables independent versioning and shared use across SqlClient and the AKV provider (which had its own AKVEventSource, now deleted).

Key Changes

Area	What Changed
New package	`Microsoft.Data.SqlClient.Extensions.Logging` — contains `SqlClientEventSource`, `SqlClientMetrics`, `SqlClientEventScope`, and scope types
Core driver	`SqlClientEventSource.cs` reduced to a ~43-line `SqlClientDiagnostics` bridge; 28 source files updated from `TryEventScope`/`TrySNIEventScope` → `SqlClientEventScope`
AKV provider	Deleted `AKVEventSource.cs`; AKV now uses the shared `SqlClientEventSource.Log` from the Logging package
Build	`build.proj` gains Logging targets; nuspec files add Logging dependency across all TFMs
Pipelines	Consolidated into unified OneBranch official/non-official pipelines with selective build params, approval service, ESRP signing for Logging, reusable publish job with dry-run; deleted 9 standalone pipeline/variable files
Docs	Added `PackageReadme.md` for all 6 packages; new OneBranch pipeline design spec (522 lines); updated `AGENTS.md`

Checklist

No breaking changes — logging behavior preserved via the extracted package as a dependency

…gned DLLs).

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/steps/compound-esrp-dll-signing-step.yml

eng/pipelines/steps/compound-esrp-nuget-signing-step.yml

src/Microsoft.Data.SqlClient.Extensions/Azure/src/AzureVersions.props

- Removed un-useful comments.

Copilot

Pull request overview

Copilot reviewed 127 out of 129 changed files in this pull request and generated 1 comment.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

- Changed Stress Tests to use project references to get rid of a bunch of headaches.

paulmedynski

Phew - I finally approve 😅 Now fingers crossed all of the pipeline runs work!

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

...ata.SqlClient/tests/StressTests/SqlClient.Stress.Framework/SqlClient.Stress.Framework.csproj

Copilot

Pull request overview

Copilot reviewed 134 out of 136 changed files in this pull request and generated 5 comments.

tools/props/Versions.props

...rosoft.Data.SqlClient/tests/StressTests/SqlClient.Stress.Tests/SqlClient.Stress.Tests.csproj

src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj

src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/MetricsTest.cs

paulmedynski

Commentary for reviewers.

eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml

eng/pipelines/steps/compound-pack-csproj-step.yml

mdaigle · 2026-02-24T18:18:12Z

PR pipelines look good. Let's see what happens in the signing pipelines.

Conflicts: src/Microsoft.Data.SqlClient.sln src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj

Copilot

Pull request overview

Copilot reviewed 134 out of 136 changed files in this pull request and generated 2 comments.

eng/pipelines/common/templates/steps/ci-project-build-step.yml

src/Microsoft.Data.SqlClient.Extensions/Logging/src/LoggingVersions.props

cheenamalhotra added 30 commits February 19, 2026 09:55

Initialize Logging package

88b5e91

Update Event Scope type names

ed287b5

Include Logging in package ref

f49e21a

Cleanup pipelines, add non-official as well

9a412a8

Include SNK signing key

c629a27

Rename pipeline

8aba060

Fix keywords

8c14916

Fix pipelines to not release if no release job is selected

4ae5f15

Notification based release stage + fix build number format

8b4ab2e

Conditional execution

991e2af

Add back the revision number decimal

2a20bcd

Update ESRP version + split build number

f1a52b6

Fix the build job to build and pack separately (as we need to pack si…

a5518e6

…gned DLLs).

Fix for APIScan failure, ensure DLLs are copied first.

7c651a4

Include readme files in NuGet packages

2f60302

Fix APIScan issue

0a19676

Fix build error and APIScan errors

69b55b5

download packages before building dependent packages

8c3a2b0

Fix azure project build by providing abstractions package version

f95382a

Rename file to Readme in all packages

e86f3f1

Enable APIScan and include instructions for onebranch pipelines.

0507f98

Pass effective logging package version to AKV build

eecfc11

Fix

71fa038

Include ob_outputDirectory variable, and other fixes

8fc0ec4

Implement approval service

95a1e5b

Configure ob_release params for approval service

24b64f7

Skip building packages when not requested.

c3f9d85

Split environments (prod v/s non-prod)

648a3e6

Touch-ups to job names

2f7a410

Fix release stage to be deployment job

2cedac3

paulmedynski requested changes Feb 23, 2026

View reviewed changes

- Factored out the common parts of the OneBranch pipelines.

2c35310

- Removed un-useful comments.

Copilot AI review requested due to automatic review settings February 23, 2026 20:49

Copilot started reviewing on behalf of paulmedynski February 23, 2026 20:51 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

eng/pipelines/common/templates/jobs/build-signed-package-job.yml Outdated Show resolved Hide resolved

paulmedynski requested changes Feb 23, 2026

View reviewed changes

eng/pipelines/common/templates/jobs/build-signed-package-job.yml Outdated Show resolved Hide resolved

- Fixed typo in ApiScan variables.

f9b4c1c

- Changed Stress Tests to use project references to get rid of a bunch of headaches.

paulmedynski previously approved these changes Feb 24, 2026

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj Show resolved Hide resolved

...ata.SqlClient/tests/StressTests/SqlClient.Stress.Framework/SqlClient.Stress.Framework.csproj Show resolved Hide resolved

Fixed strong name signing to occur on all OneBranch pipelines.

30e7e71

Copilot AI review requested due to automatic review settings February 24, 2026 14:21

paulmedynski dismissed their stale review via 30e7e71 February 24, 2026 14:21

Copilot started reviewing on behalf of paulmedynski February 24, 2026 14:22 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Fixed InternalsVisibleTo for signed builds.

f4de530

paulmedynski previously approved these changes Feb 24, 2026

View reviewed changes

apoorvdeshmukh previously approved these changes Feb 24, 2026

View reviewed changes

mdaigle reviewed Feb 24, 2026

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml Show resolved Hide resolved

eng/pipelines/steps/compound-pack-csproj-step.yml Show resolved Hide resolved

mdaigle previously approved these changes Feb 24, 2026

View reviewed changes

Merge branch 'main' into dev/cheena/logging-package

e85687c

Conflicts: src/Microsoft.Data.SqlClient.sln src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj

Copilot AI review requested due to automatic review settings February 24, 2026 18:35

paulmedynski dismissed stale reviews from mdaigle, apoorvdeshmukh, and themself via e85687c February 24, 2026 18:35

Copilot started reviewing on behalf of paulmedynski February 24, 2026 18:35 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

eng/pipelines/common/templates/steps/ci-project-build-step.yml Show resolved Hide resolved

src/Microsoft.Data.SqlClient.Extensions/Logging/src/LoggingVersions.props Show resolved Hide resolved

paulmedynski approved these changes Feb 24, 2026

View reviewed changes

mdaigle approved these changes Feb 24, 2026

View reviewed changes

paulmedynski merged commit e55e689 into main Feb 24, 2026
306 of 316 checks passed

paulmedynski deleted the dev/cheena/logging-package branch February 24, 2026 23:01

Conversation

cheenamalhotra commented Feb 19, 2026

Summary

Key Changes

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaigle commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants