Removed PackSqlServer from BuildAllConfigurations target#3991
Conversation
…package polluting the signing verification steps of our OneBranch Official pipeline.
There was a problem hiding this comment.
Pull request overview
Removes PackSqlServer from the top-level BuildAllConfigurations target in build.proj to avoid generating extra packages during “build all configurations” runs (notably in official pipeline signing/verification scenarios), and updates build docs accordingly.
Changes:
- Add a new
BuildSqlClienttarget and simplifyBuildAllConfigurationsdependencies (droppingPackSqlServer). - Update
BUILDGUIDE.mdexamples to use the updated target flow (includingBuildSqlClient).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build.proj | Removes PackSqlServer from BuildAllConfigurations and introduces BuildSqlClient target. |
| BUILDGUIDE.md | Updates “Package references” build command examples to reflect new/cleaned targets. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
==========================================
- Coverage 72.54% 67.09% -5.46%
==========================================
Files 287 282 -5
Lines 43149 67171 +24022
==========================================
+ Hits 31303 45068 +13765
- Misses 11846 22103 +10257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
I mistakenly added the
PackSqlServertarget toBuildAllConfigurationsa few commits ago. It was polluting the signing verification steps of our OneBranch Official pipeline. I cleaned up these targets a bit and tested them on the command line. I'm running an Official pipeline to confirm.