Skip to content

Removed PackSqlServer from BuildAllConfigurations target#3991

Merged
paulmedynski merged 2 commits into
mainfrom
dev/paul/sqlserver
Feb 27, 2026
Merged

Removed PackSqlServer from BuildAllConfigurations target#3991
paulmedynski merged 2 commits into
mainfrom
dev/paul/sqlserver

Conversation

@paulmedynski
Copy link
Copy Markdown
Contributor

Description

I mistakenly added the PackSqlServer target to BuildAllConfigurations a few commits ago. It was polluting the signing verification steps of our OneBranch Official pipeline. I cleaned up these targets a bit and tested them on the command line. I'm running an Official pipeline to confirm.

…package polluting the signing verification steps of our OneBranch Official pipeline.
@paulmedynski paulmedynski added this to the 7.0.0-preview4 milestone Feb 27, 2026
@paulmedynski paulmedynski requested a review from a team as a code owner February 27, 2026 20:26
Copilot AI review requested due to automatic review settings February 27, 2026 20:26
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 27, 2026
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Feb 27, 2026
Comment thread build.proj
Comment thread build.proj
Comment thread BUILDGUIDE.md
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes PackSqlServer from the top-level BuildAllConfigurations target in build.proj to avoid generating extra packages during “build all configurations” runs (notably in official pipeline signing/verification scenarios), and updates build docs accordingly.

Changes:

  • Add a new BuildSqlClient target and simplify BuildAllConfigurations dependencies (dropping PackSqlServer).
  • Update BUILDGUIDE.md examples to use the updated target flow (including BuildSqlClient).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
build.proj Removes PackSqlServer from BuildAllConfigurations and introduces BuildSqlClient target.
BUILDGUIDE.md Updates “Package references” build command examples to reflect new/cleaned targets.

Comment thread build.proj
Comment thread BUILDGUIDE.md Outdated
Comment thread BUILDGUIDE.md Outdated
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Feb 27, 2026
@samsharma2700 samsharma2700 self-assigned this Feb 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.09%. Comparing base (a561ed3) to head (5c035ce).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (a561ed3) and HEAD (5c035ce). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a561ed3) HEAD (5c035ce)
CI-SqlClient 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3991      +/-   ##
==========================================
- Coverage   72.54%   67.09%   -5.46%     
==========================================
  Files         287      282       -5     
  Lines       43149    67171   +24022     
==========================================
+ Hits        31303    45068   +13765     
- Misses      11846    22103   +10257     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 67.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit b77c202 into main Feb 27, 2026
296 checks passed
@paulmedynski paulmedynski deleted the dev/paul/sqlserver branch February 27, 2026 22:22
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants