remove more duplicate lookups#4089
Merged
mdaigle merged 2 commits intoApr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors enclave provider creation in EnclaveDelegate.Crypto.cs to avoid redundant ConcurrentDictionary lookups when initializing providers for different attestation protocols.
Changes:
- Removes duplicate dictionary lookups by assigning the newly created provider directly to
sqlColumnEncryptionEnclaveProvider. - Stores the provider instance into
s_enclaveProviderswithout re-reading it back.
Replace ContainsKey + indexer patterns with TryGetParsetableValue (for connection options) and TryGetValue (for _appDomainKeyHash) to avoid double dictionary lookups, remove variable shadowing, and make intent clearer. Existing logic and assertions are preserved.
SimonCropp
changed the title
Contributor
Author
|
sorry. i dont know how i missed these on the previous pass |
cheenamalhotra
approved these changes
Apr 8, 2026
mdaigle
approved these changes
Apr 16, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4089 +/- ##
==========================================
- Coverage 73.22% 64.19% -9.03%
==========================================
Files 280 271 -9
Lines 43000 65722 +22722
==========================================
+ Hits 31486 42190 +10704
- Misses 11514 23532 +12018
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SimonCropp
deleted the
remove-duplicate-lookups-in-EnclaveDelegate.Crypto.cs
branch
paulmedynski
pushed a commit
that referenced
this pull request
May 7, 2026
* remove duplicate lookups in EnclaveDelegate.Crypto.cs * Use TryGet methods to avoid double lookups Replace ContainsKey + indexer patterns with TryGetParsetableValue (for connection options) and TryGetValue (for _appDomainKeyHash) to avoid double dictionary lookups, remove variable shadowing, and make intent clearer. Existing logic and assertions are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.