Skip to content

Pin .NET SDK to 10.0.105#4165

Merged
paulmedynski merged 2 commits intomainfrom
dev/paul/net-version
Apr 8, 2026
Merged

Pin .NET SDK to 10.0.105#4165
paulmedynski merged 2 commits intomainfrom
dev/paul/net-version

Conversation

@paulmedynski
Copy link
Copy Markdown
Contributor

Description

Pinned our .NET SDK at exactly 10.0.105 to remain compatible with our CI agents that use MSBuild 17.x.

@paulmedynski paulmedynski added this to the 7.1.0-preview1 milestone Apr 8, 2026
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Apr 8, 2026
@paulmedynski paulmedynski requested a review from a team as a code owner April 8, 2026 12:37
Copilot AI review requested due to automatic review settings April 8, 2026 12:37
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Apr 8, 2026
@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the repository’s .NET SDK selection to a specific .NET 10 SDK patch to maintain compatibility with the current Windows CI toolchain (VS 2022 / MSBuild 17.x).

Changes:

  • Updated global.json SDK version from 10.0.104 to 10.0.105.
  • Disabled SDK roll-forward to prevent selecting newer SDK bands that may require newer MSBuild.
  • Refreshed the header comment to document the CI/MSBuild constraint.

Comment thread global.json Outdated
Comment thread global.json Outdated
@paulmedynski paulmedynski added the Hotfix 7.0.1 When this PR merges, automatically open a PR to cherry-pick to the 7.0.1 branch label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.54%. Comparing base (ea6091b) to head (580846d).
⚠️ Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ea6091b) and HEAD (580846d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ea6091b) HEAD (580846d)
CI-SqlClient 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4165      +/-   ##
==========================================
- Coverage   74.26%   66.54%   -7.72%     
==========================================
  Files         279      274       -5     
  Lines       42980    65796   +22816     
==========================================
+ Hits        31917    43786   +11869     
- Misses      11063    22010   +10947     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 66.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski enabled auto-merge (squash) April 8, 2026 18:07
Copy link
Copy Markdown
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw there's a way to specify just major+minor version for this to avoid the patch version causing issues. But this is fine solution for the foreseeable future

@paulmedynski paulmedynski merged commit d197d6a into main Apr 8, 2026
299 checks passed
@paulmedynski paulmedynski deleted the dev/paul/net-version branch April 8, 2026 18:14
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Apr 8, 2026
github-actions Bot pushed a commit that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. Hotfix 7.0.1 When this PR merges, automatically open a PR to cherry-pick to the 7.0.1 branch

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants