[7.1.0-preview1] ESRP Globbing#4245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes OneBranch ESRP DLL signing in internal/main by updating the file search pattern to use minimatch globbing, so signing finds DLLs produced under target-framework subfolders in $(BUILD_OUTPUT).
Changes:
- Update ESRP DLL signing
patternfrom a root-only filename match to a recursive glob (**/...) to match nested build outputs.
cheenamalhotra
approved these changes
Apr 28, 2026
Member
|
Might as well also look into paths here: (I suspect this one needs an input value or should be changed) and Are they looking alright? |
mdaigle
approved these changes
Apr 28, 2026
paulmedynski
pushed a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ESRP code signing is failing on internal/main because the search pattern doesn't match any dll files. This is because the esrp task is searching for the dll in the root of the build output. Instead it should be using a glob pattern to search all folders in the build output path.
Small issue, could've been caught if we were allowed to run ESRP signing against non-official pipelines, or run official pipelines against arbitrary branches, but nooooo...