Skip to content

Fix package path for release#4258

Merged
cheenamalhotra merged 1 commit into
mainfrom
dev/mdaigle/fix-package-path
May 4, 2026
Merged

Fix package path for release#4258
cheenamalhotra merged 1 commit into
mainfrom
dev/mdaigle/fix-package-path

Conversation

@mdaigle
Copy link
Copy Markdown
Contributor

@mdaigle mdaigle commented May 4, 2026

This pull request updates the pipeline configuration to change the expected location of NuGet package artifacts from the packages/ directory to Package-Release/. This ensures that all package publishing steps reference the correct artifact paths after a directory structure change.

Pipeline artifact path updates:

  • Updated the packageToPush variable in publish-nuget-package-job.yml to use the Package-Release/ directory instead of packages/.

  • Updated all packagePath parameters in release-stages.yml for the following packages to use the Package-Release/ directory:

    • Microsoft.SqlServer.Server
    • Microsoft.Data.SqlClient.Internal.Logging
    • Microsoft.Data.SqlClient.Extensions.Abstractions
    • Microsoft.Data.SqlClient
    • Microsoft.Data.SqlClient.Extensions.Azure
    • Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider

Copilot AI review requested due to automatic review settings May 4, 2026 17:57
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board May 4, 2026
@mdaigle mdaigle added this to the 7.1.0-preview1 milestone May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OneBranch NuGet publishing pipeline templates to look for built .nupkg artifacts under Package-Release/ instead of packages/, aligning release publishing steps with an intended artifact directory structure change.

Changes:

  • Updated release-stages.yml to pass packagePath values rooted at Package-Release/ for all released packages.
  • Updated publish-nuget-package-job.yml to default the packageToPush glob to Package-Release/{packageName}.*.nupkg when packagePath isn’t provided.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
eng/pipelines/onebranch/stages/release-stages.yml Updates per-package packagePath values used by the release stage publish jobs.
eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml Changes the default publish glob to target Package-Release/ instead of packages/.

Comment thread eng/pipelines/onebranch/stages/release-stages.yml
Comment thread eng/pipelines/onebranch/stages/release-stages.yml
Comment thread eng/pipelines/onebranch/stages/release-stages.yml
Comment thread eng/pipelines/onebranch/stages/release-stages.yml
Comment thread eng/pipelines/onebranch/stages/release-stages.yml
Comment thread eng/pipelines/onebranch/jobs/publish-nuget-package-job.yml
@cheenamalhotra cheenamalhotra marked this pull request as ready for review May 4, 2026 19:20
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner May 4, 2026 19:20
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board May 4, 2026
@cheenamalhotra cheenamalhotra merged commit 6d26a9e into main May 4, 2026
10 of 11 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/mdaigle/fix-package-path branch May 4, 2026 19:22
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board May 4, 2026
paulmedynski pushed a commit that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants