Cleanup: git config, implicit usings, test common fixes, and build props#4301
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Housekeeping PR focused on reducing repository noise (git config + generated files), cleaning up MSBuild metadata, and streamlining test common sources to rely more on project-level compiler settings.
Changes:
- Simplifies
.gitattributesand trims.gitignore(including adding a pattern for C# language server cache files). - Enables implicit usings in
Microsoft.Data.SqlClient.TestCommonand removes now-redundantusingdirectives / nullable pragmas from common test code. - Cleans up build/analysis metadata files (MSBuild props/targets and the ManualTests ruleset).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/targets/RepositoryInfo.targets | Reduces build log verbosity for the translated ScmRepositoryUrl message. |
| tools/props/AssemblyRef.props | Simplifies MSBuild project header metadata. |
| tools/props/AssemblyInfo.props | Simplifies MSBuild project header metadata. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.ruleset | Removes Ruleset ToolsVersion metadata and normalizes formatting. |
| src/Microsoft.Data.SqlClient/tests/Common/Microsoft.Data.SqlClient.TestCommon.csproj | Enables <ImplicitUsings> for the TestCommon helper library. |
| src/Microsoft.Data.SqlClient/tests/Common/LocalAppContextSwitchesHelper.cs | Removes redundant using directives now covered by implicit usings. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/DatabaseObjects/DatabaseObject.cs | Removes redundant using directives and normalizes doc comment whitespace. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/CspCertificateFixture.cs | Removes redundant using directives now covered by implicit usings. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/ColumnMasterKeyCertificateFixture.cs | Removes redundant using directives now covered by implicit usings. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/ColumnEncryptionCertificateFixture.cs | Removes redundant using directives now covered by implicit usings. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/CertificateFixtureBase.cs | Removes redundant using directives and normalizes whitespace. |
| src/Microsoft.Data.SqlClient/tests/Common/Fixtures/AzureKeyVaultKeyFixtureBase.cs | Fixes malformed header comment and removes redundant using directives. |
| src/Microsoft.Data.SqlClient/tests/Common/DisposableArray.cs | Removes redundant using directives and file-level nullable pragma (project-level nullable applies). |
| src/Directory.Build.props | Simplifies MSBuild project header metadata and clarifies versioning comments. |
| .gitignore | Trims ignore list and adds ignore for *.lscache. |
| .gitattributes | Simplifies to line-ending normalization + workflow lock file attributes. |
paulmedynski
commented
May 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
==========================================
- Coverage 66.04% 64.78% -1.27%
==========================================
Files 275 279 +4
Lines 42976 66211 +23235
==========================================
+ Hits 28383 42892 +14509
- Misses 14593 23319 +8726
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apoorvdeshmukh
approved these changes
May 29, 2026
priyankatiwari08
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Housekeeping cleanup that removes unnecessary items and fixes minor issues:
.gitattributesand.gitignoreby removing redundant entriesusingdirectives from test common filestools/props/AssemblyInfo.props,AssemblyRef.props, andtools/targets/RepositoryInfo.targetsManualTesting.Tests.rulesetChanges
Checklist