Skip to content

Tests | Address transient errors in CI pipelines#4314

Merged
cheenamalhotra merged 3 commits into
mainfrom
dev/cheena/intermittent-failures
May 29, 2026
Merged

Tests | Address transient errors in CI pipelines#4314
cheenamalhotra merged 3 commits into
mainfrom
dev/cheena/intermittent-failures

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented May 28, 2026

All CI pipelines were affected due to these common issues:

  • Transient errors when donwloading .NET version
  • Mark Flaky tests.
  • Fix TestDefaultAppContextSwitchValues to not fail intermittently.

Copilot AI review requested due to automatic review settings May 28, 2026 03:24
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board May 28, 2026
@cheenamalhotra cheenamalhotra added this to the 7.1.0-preview2 milestone May 28, 2026
@cheenamalhotra cheenamalhotra changed the title Address transient errors in CI pipelines Tests | Address transient errors in CI pipelines May 28, 2026
@cheenamalhotra cheenamalhotra added Area\Tests Issues that are targeted to tests or test projects Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. labels May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses CI flakiness by adding task-level retries to .NET install steps and quarantining two intermittently failing transient-fault failover tests.

Changes:

  • Add [Trait("Category", "flaky")] to two retry-disabled transient fault tests in ConnectionFailoverTests.cs.
  • Add retryCountOnTaskFailure: 3 to the SDK install, runtime install loop, and ARM64 PowerShell install steps in install-dotnet.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs Quarantines two flaky transient-fault retry-disabled tests so they run in the separate flaky pipeline step.
eng/pipelines/steps/install-dotnet.yml Adds task-level retries to .NET SDK/runtime install tasks to mitigate transient CDN/network failures.

@cheenamalhotra cheenamalhotra marked this pull request as ready for review May 28, 2026 03:35
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner May 28, 2026 03:35
@cheenamalhotra cheenamalhotra added Hotfix 7.0.2 PRs targeting main that should be backported to release/7.0 for the 7.0.2 release. Hotfix 6.1.6 PRs targeting main that should be backported to release/6.1 for the 6.1.6 release. labels May 28, 2026
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board May 28, 2026
Copilot AI review requested due to automatic review settings May 28, 2026 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.71%. Comparing base (c724554) to head (ad51580).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4314      +/-   ##
==========================================
- Coverage   66.57%   64.71%   -1.86%     
==========================================
  Files         284      279       -5     
  Lines       43301    66219   +22918     
==========================================
+ Hits        28827    42853   +14026     
- Misses      14474    23366    +8892     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra cheenamalhotra merged commit 3499785 into main May 29, 2026
303 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board May 29, 2026
@cheenamalhotra cheenamalhotra deleted the dev/cheena/intermittent-failures branch May 29, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. Area\Tests Issues that are targeted to tests or test projects Hotfix 6.1.6 PRs targeting main that should be backported to release/6.1 for the 6.1.6 release. Hotfix 7.0.2 PRs targeting main that should be backported to release/7.0 for the 7.0.2 release.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants