PR Pipeline - Azure + AE by benrr101 · Pull Request #4338 · dotnet/SqlClient

benrr101 · 2026-06-03T21:06:47Z

Description

This PR adds to the PR pipeline in the previous PR #4308 and adds the following test jobs:

SqlClient Manual test sets 123 against Azure
SqlClient Manual test sets AE against localhost (in release mode)

Testing

pr-pipeline on internal ADO - https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=155151&view=results
sqlclient-pr on public ADO - https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=155152&view=results
sqlient-non-official - https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=154956&view=results

# Conflicts: # src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs

Copilot

Pull request overview

This PR extends the new PR validation pipeline to run additional SqlClient manual test coverage in CI-like PR validation scenarios, specifically adding Azure SQL manual test runs and an Always Encrypted (AE) manual test run in Release configuration.

Changes:

Adds SqlClient manual test set 123 execution against Azure SQL, alongside existing localhost manual coverage.
Adds a localhost Always Encrypted manual test run (TestSet=AE) forced to Release configuration.
Simplifies PR pipeline templates by removing PR-specific wrapper step templates and switching PR jobs/stages to directly use the shared eng/pipelines/common/steps/* templates.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Microsoft.Data.SqlClient/tests/ManualTests/BulkCopy/CopyAllFromReaderConnectionCloseOnEventAsync.cs	Skips this BulkCopy manual test on Azure servers via an additional `IsNotAzureServer` condition.
eng/pipelines/pr/stages/test-stages.yml	Adds Azure manual test execution for set `123`, and adds localhost AE manual execution (`AE`) in Release mode.
eng/pipelines/pr/jobs/test-sqlclientmanual-job.yml	Parameterizes manual test jobs by config/test set; adds conditional local server setup and passes `TestSet` to `build.proj`.
eng/pipelines/pr/jobs/test-buildproj-job.yml	Updates job bootstrap to use shared install/restore steps and inlines the `build.proj` test invocation.
eng/pipelines/pr/stages/pack-stage.yml	Replaces PR-specific dotnet install wrapper with shared common install + tool restore steps.
eng/pipelines/pr/steps/pack-buildproj-step.yml	Renames the task display name to clarify it performs packing.
eng/pipelines/pr/steps/test-buildproj-step.yml	Deleted (previously a PR-specific wrapper step for running build.proj test targets).
eng/pipelines/pr/steps/install-dotnet.yml	Deleted (previously a PR-specific wrapper around the common install-dotnet and tool restore steps).
eng/pipelines/pr/steps/build-buildproj-step.yml	Deleted (previously a PR-specific wrapper step for running build.proj build targets).

benrr101 · 2026-06-04T18:45:31Z

+      - task: DotNetCoreCLI@2
+        displayName: 'Test: ${{ parameters.packageShortName }}${{ parameters.testProject }}'
+        inputs:
+          command: build
+          projects: build.proj


benrr101 · 2026-06-04T18:46:02Z

+      - task: DotNetCoreCLI@2
+        displayName: 'Test: SqlClientManual ${{ parameters.testSet }}'
+        inputs:
+          command: build
+          projects: build.proj


Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

+        [Trait("Category", "flaky")] // Doesn't work well on Azure.
        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
        [MemberData(nameof(SqlTypeTestData), DisableDiscoveryEnumeration = true)]


+        [Trait("Category", "flaky")] // Doesn't work well on Azure.
        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
        [MemberData(nameof(SqlTypeTestData), DisableDiscoveryEnumeration = true)]


+      # Execute the test target
+      - task: DotNetCoreCLI@2
+        displayName: 'Test: ${{ parameters.packageShortName }}${{ parameters.testProject }}'
+        inputs:
+          command: build
+          projects: build.proj
+          verbosity: detailed
+          arguments: >-
+            -t:Test${{ parameters.packageShortName }}${{ parameters.testProject }}
+            -p:Configuration=${{ parameters.buildConfiguration }}
+            -p:BuildNumber='$(Build.BuildNumber)'
+            -p:BuildSuffix='${{ parameters.buildSuffix }}'
+            -p:TestFramework=${{ parameters.platformDotnet }}


codecov · 2026-06-05T12:44:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (bfbdd30) to head (a4060e8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
- Coverage   66.69%   63.88%   -2.81%     
==========================================
  Files         284      279       -5     
  Lines       43238    66069   +22831     
==========================================
+ Hits        28836    42210   +13374     
- Misses      14402    23859    +9457

Flag	Coverage Δ
CI-SqlClient	`?`
PR-SqlClient-Project	`63.88% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski · 2026-06-05T16:08:37Z

+        inputs:
+          command: build
+          projects: build.proj
+          verbosity: detailed


I think we want a top-level parameter for this (like the other pipelines), and default to normal.

benrr101 added 10 commits June 3, 2026 15:53

Let's just enable azure stuff and see what breaks.

dc75d06

config 🔨

15714a6

this syntax is garbage

66278ae

Job names.

1e98826

🤖 Run AE in release mode separately, exlude AE from azure test runs.

7d53a40

Decompose the single step test-buildproj-job.yml file

b5e74a5

platformDotnet

392ceec

Manual test name

472ec0c

Disable sqlbulkcopy that fails on azure

bff1f6b

# Conflicts: # src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs

Feedback from previous PR

1076211

benrr101 added this to the 7.1.0-preview2 milestone Jun 3, 2026

Copilot AI review requested due to automatic review settings June 3, 2026 21:06

benrr101 added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Jun 3, 2026

github-project-automation Bot added this to SqlClient Board Jun 3, 2026

github-project-automation Bot moved this to To triage in SqlClient Board Jun 3, 2026

Copilot started reviewing on behalf of benrr101 June 3, 2026 21:07 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

benrr101 assigned cheenamalhotra and paulmedynski Jun 4, 2026

benrr101 added 2 commits June 4, 2026 13:41

Flaky tests in azure.

0ea0f80

Another flaky test.

a4060e8

Copilot AI review requested due to automatic review settings June 4, 2026 22:42

Copilot started reviewing on behalf of benrr101 June 4, 2026 22:42 View session

benrr101 marked this pull request as ready for review June 4, 2026 22:43

benrr101 requested a review from a team as a code owner June 4, 2026 22:43

Copilot AI reviewed Jun 4, 2026

View reviewed changes

paulmedynski moved this from To triage to In review in SqlClient Board Jun 5, 2026

paulmedynski requested changes Jun 5, 2026

View reviewed changes

github-project-automation Bot moved this from In review to Waiting for customer in SqlClient Board Jun 5, 2026

paulmedynski added the Author attention needed PRs that require author to respond or make updates to PR. label Jun 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR Pipeline - Azure + AE#4338

PR Pipeline - Azure + AE#4338
benrr101 wants to merge 12 commits into
mainfrom
dev/russellben/pr-azure

benrr101 commented Jun 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

benrr101 Jun 4, 2026

Uh oh!

benrr101 Jun 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

paulmedynski Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

benrr101 commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

benrr101 Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

benrr101 Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benrr101 commented Jun 3, 2026 •

edited

Loading

codecov Bot commented Jun 5, 2026 •

edited

Loading