Skip to content

Remove deprecated [Android.Runtime.Preserve] attribute #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2025
Merged

Remove deprecated [Android.Runtime.Preserve] attribute #1322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8c3b83
Initial plan
Copilot Dec 2, 2025
09d9d19
Remove deprecated [Android.Runtime.Preserve] attribute from Task.cs
Copilot Dec 2, 2025
ecfaf60
Re-add Android.Runtime namespace for IJavaObject type
Copilot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions source/com.google.android.gms/play-services-tasks/Additions/Task.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,15 @@ public static System.Threading.Tasks.Task AsAsync (this Task task)
}
}

[Android.Runtime.Preserve]
class AwaitableTaskCompleteListener<[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)] TResult> : Java.Lang.Object, IOnCompleteListener where TResult : class, IJavaObject
{
System.Threading.Tasks.TaskCompletionSource<TResult> taskCompletionSource;

[Android.Runtime.Preserve]
public AwaitableTaskCompleteListener ()
{
taskCompletionSource = new System.Threading.Tasks.TaskCompletionSource<TResult> ();
}

[Android.Runtime.Preserve]
public void OnComplete (Task task)
{
if (task.IsSuccessful) {
Expand All @@ -70,13 +67,11 @@ public void OnComplete (Task task)
}
}

[Android.Runtime.Preserve]
public System.Threading.Tasks.Task<TResult> AwaitAsync ()
{
return taskCompletionSource.Task;
}

[Android.Runtime.Preserve]
public TaskAwaiter<TResult> GetAwaiter ()
{
return taskCompletionSource.Task.GetAwaiter ();
Expand All @@ -86,19 +81,15 @@ public TaskAwaiter<TResult> GetAwaiter ()

namespace Android.Gms.Tasks
{
[Android.Runtime.Preserve]
public partial class Task
{
[Android.Runtime.Preserve]
public virtual Java.Lang.Object Result {
get { return RawResult; }
}
}

[Android.Runtime.Preserve]
public partial class TaskCompletionSource
{
[Android.Runtime.Preserve]
public virtual Task Task { get { return GetTask (); } }
}
}