Add /review agentic workflow for android-tools-reviewer#346
Add /review agentic workflow for android-tools-reviewer#346jonathanpeppers merged 2 commits intomainfrom
/review agentic workflow for android-tools-reviewer#346Conversation
Port the android-tools-reviewer from a Copilot CLI skill to a GitHub Agentic Workflow triggered by the `/review` slash command on pull requests. The workflow performs automated code review using the existing review rules and posts findings as inline review comments and a review summary via safe-outputs. Changes: - Create `.github/workflows/android-tools-reviewer.md` with slash_command trigger, read-only permissions, claude-opus-4.6 model, network allowlist, min-integrity: none for external contributors, roles restriction to admin/maintainer/write, and safe-outputs for PR review comments and review submission - Create `.github/agents/agentic-workflows.agent.md` dispatcher - Create `.github/aw/actions-lock.json` for pinned action SHAs - Compile `.github/workflows/android-tools-reviewer.lock.yml` - Update SKILL.md to remove submit_review.cs script workflow and add CI status checking, Copilot-authored PR handling, and direct review posting via safe-outputs - Delete `.github/skills/android-tools-reviewer/scripts/submit_review.cs` (no longer needed — the workflow uses safe-outputs instead of gh api) - Update `copilot-setup-steps.yml` to install gh-aw CLI extension and bump actions/checkout to v6 - Update `.gitattributes` to mark lock files as linguist-generated - Remove stale `submit_review.cs` reference from copilot-instructions.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add missing sections: Problems This Solves, How to Use, Key Features, Important Notes, and detailed Load when / Use cases per prompt. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
We'll have to merge to test, I believe. |
There was a problem hiding this comment.
Pull request overview
Ports android-tools-reviewer from a script-based Copilot CLI skill to a GitHub Agentic Workflow triggered by the /review slash command, using safe-outputs to publish inline comments and the final review directly.
Changes:
- Add the
/reviewagentic workflow source (.md) plus compiled.lock.yml, and introduce an agentic-workflows dispatcher agent. - Update CI/setup to install the
gh-awCLI extension and bumpactions/checkout. - Remove the old
submit_review.cssubmission script and update skill/docs to reflect direct review posting.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/copilot-setup-steps.yml | Updates setup workflow to use newer checkout and install gh-aw CLI extension. |
| .github/workflows/android-tools-reviewer.md | Defines the /review slash-command agentic workflow prompt/instructions and safe-outputs limits. |
| .github/workflows/android-tools-reviewer.lock.yml | Adds the compiled workflow that runs the agent, threat detection, and safe-outputs submission pipeline. |
| .github/skills/android-tools-reviewer/scripts/submit_review.cs | Removes the old gh api-based batched review submission script. |
| .github/skills/android-tools-reviewer/SKILL.md | Updates reviewer methodology to post reviews directly and adds CI-status checking guidance. |
| .github/copilot-instructions.md | Removes the now-stale reference to running the removed submission script. |
| .github/aw/actions-lock.json | Introduces pinned SHAs for agentic workflow actions (gh-aw setup). |
| .github/agents/agentic-workflows.agent.md | Adds a dispatcher agent for creating/updating/debugging gh-aw workflows. |
| .gitattributes | Marks workflow lock files as generated and configures merges accordingly. |
|
I do not really understand why we added |
|
I think the |
Port the
android-tools-reviewerfrom a Copilot CLI skill (which usedsubmit_review.cs+gh api) to a GitHub Agentic Workflow triggered by the/reviewslash command on pull requests. This follows the same pattern established in dotnet/android (example).The workflow uses safe-outputs to post inline review comments and a review summary directly, removing the need for the custom C# submission script.
Changes
.github/workflows/android-tools-reviewer.md-- agentic workflow with/reviewslash command trigger,claude-opus-4.6model,roles: [admin, maintainer, write],min-integrity: nonefor external contributor PRs, and safe-outputs for review comments/submission.github/workflows/android-tools-reviewer.lock.yml-- compiled lock file (gh-aw v0.68.3).github/agents/agentic-workflows.agent.md-- gh-aw dispatcher agent (matches dotnet/android).github/aw/actions-lock.json-- pinned action SHAs.github/workflows/copilot-setup-steps.yml-- install gh-aw CLI extension, bumpactions/checkoutto v6.gitattributes-- mark*.lock.ymlaslinguist-generatedwithmerge=ours.github/skills/android-tools-reviewer/SKILL.md-- updated workflow to remove script-based submission, add CI status checking, Copilot-authored PR handling, and direct review posting.github/copilot-instructions.md-- remove stalesubmit_review.csreferenceRemoved
.github/skills/android-tools-reviewer/scripts/submit_review.cs-- replaced by safe-outputs; the agentic workflow posts reviews directly via GitHub tools