Skip to content

Add /review agentic workflow for android-tools-reviewer#346

Merged
jonathanpeppers merged 2 commits intomainfrom
jonathanpeppers/agentic-workflow-port
Apr 28, 2026
Merged

Add /review agentic workflow for android-tools-reviewer#346
jonathanpeppers merged 2 commits intomainfrom
jonathanpeppers/agentic-workflow-port

Conversation

@jonathanpeppers
Copy link
Copy Markdown
Member

Port the android-tools-reviewer from a Copilot CLI skill (which used submit_review.cs + gh api) to a GitHub Agentic Workflow triggered by the /review slash command on pull requests. This follows the same pattern established in dotnet/android (example).

The workflow uses safe-outputs to post inline review comments and a review summary directly, removing the need for the custom C# submission script.

Changes

  • .github/workflows/android-tools-reviewer.md -- agentic workflow with /review slash command trigger, claude-opus-4.6 model, roles: [admin, maintainer, write], min-integrity: none for external contributor PRs, and safe-outputs for review comments/submission
  • .github/workflows/android-tools-reviewer.lock.yml -- compiled lock file (gh-aw v0.68.3)
  • .github/agents/agentic-workflows.agent.md -- gh-aw dispatcher agent (matches dotnet/android)
  • .github/aw/actions-lock.json -- pinned action SHAs
  • .github/workflows/copilot-setup-steps.yml -- install gh-aw CLI extension, bump actions/checkout to v6
  • .gitattributes -- mark *.lock.yml as linguist-generated with merge=ours
  • .github/skills/android-tools-reviewer/SKILL.md -- updated workflow to remove script-based submission, add CI status checking, Copilot-authored PR handling, and direct review posting
  • .github/copilot-instructions.md -- remove stale submit_review.cs reference

Removed

  • .github/skills/android-tools-reviewer/scripts/submit_review.cs -- replaced by safe-outputs; the agentic workflow posts reviews directly via GitHub tools

jonathanpeppers and others added 2 commits April 27, 2026 10:29
Port the android-tools-reviewer from a Copilot CLI skill to a GitHub
Agentic Workflow triggered by the `/review` slash command on pull
requests. The workflow performs automated code review using the
existing review rules and posts findings as inline review comments
and a review summary via safe-outputs.

Changes:
- Create `.github/workflows/android-tools-reviewer.md` with
  slash_command trigger, read-only permissions, claude-opus-4.6 model,
  network allowlist, min-integrity: none for external contributors,
  roles restriction to admin/maintainer/write, and safe-outputs for
  PR review comments and review submission
- Create `.github/agents/agentic-workflows.agent.md` dispatcher
- Create `.github/aw/actions-lock.json` for pinned action SHAs
- Compile `.github/workflows/android-tools-reviewer.lock.yml`
- Update SKILL.md to remove submit_review.cs script workflow and add
  CI status checking, Copilot-authored PR handling, and direct review
  posting via safe-outputs
- Delete `.github/skills/android-tools-reviewer/scripts/submit_review.cs`
  (no longer needed — the workflow uses safe-outputs instead of gh api)
- Update `copilot-setup-steps.yml` to install gh-aw CLI extension
  and bump actions/checkout to v6
- Update `.gitattributes` to mark lock files as linguist-generated
- Remove stale `submit_review.cs` reference from copilot-instructions.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add missing sections: Problems This Solves, How to Use, Key Features,
Important Notes, and detailed Load when / Use cases per prompt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 27, 2026 15:41
@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge. label Apr 27, 2026
@jonathanpeppers
Copy link
Copy Markdown
Member Author

We'll have to merge to test, I believe.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports android-tools-reviewer from a script-based Copilot CLI skill to a GitHub Agentic Workflow triggered by the /review slash command, using safe-outputs to publish inline comments and the final review directly.

Changes:

  • Add the /review agentic workflow source (.md) plus compiled .lock.yml, and introduce an agentic-workflows dispatcher agent.
  • Update CI/setup to install the gh-aw CLI extension and bump actions/checkout.
  • Remove the old submit_review.cs submission script and update skill/docs to reflect direct review posting.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/copilot-setup-steps.yml Updates setup workflow to use newer checkout and install gh-aw CLI extension.
.github/workflows/android-tools-reviewer.md Defines the /review slash-command agentic workflow prompt/instructions and safe-outputs limits.
.github/workflows/android-tools-reviewer.lock.yml Adds the compiled workflow that runs the agent, threat detection, and safe-outputs submission pipeline.
.github/skills/android-tools-reviewer/scripts/submit_review.cs Removes the old gh api-based batched review submission script.
.github/skills/android-tools-reviewer/SKILL.md Updates reviewer methodology to post reviews directly and adds CI-status checking guidance.
.github/copilot-instructions.md Removes the now-stale reference to running the removed submission script.
.github/aw/actions-lock.json Introduces pinned SHAs for agentic workflow actions (gh-aw setup).
.github/agents/agentic-workflows.agent.md Adds a dispatcher agent for creating/updating/debugging gh-aw workflows.
.gitattributes Marks workflow lock files as generated and configures merges accordingly.

Comment thread .github/workflows/android-tools-reviewer.lock.yml
Comment thread .github/skills/android-tools-reviewer/SKILL.md
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) April 27, 2026 21:54
@jonathanpeppers jonathanpeppers merged commit 3bfeba6 into main Apr 28, 2026
7 checks passed
@jonathanpeppers jonathanpeppers deleted the jonathanpeppers/agentic-workflow-port branch April 28, 2026 07:45
@simonrozsival
Copy link
Copy Markdown
Member

I do not really understand why we added .github/agents/agentic-workflows.agent.md. This is an agent that we would use to create more agentic workflows, but it's not necessary for this workflow, right? Anyway, this PR was good to merge and we can choose to remove this agent definition later.

@jonathanpeppers
Copy link
Copy Markdown
Member Author

I think the gh aw command creates this file, I must have manually removed when I did this for dotnet/android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants