Add AdbRunner.EnrichDeviceAsync to populate device metadata via getprop#385
Draft
Copilot wants to merge 2 commits into
Draft
Add AdbRunner.EnrichDeviceAsync to populate device metadata via getprop#385Copilot wants to merge 2 commits into
AdbRunner.EnrichDeviceAsync to populate device metadata via getprop#385Copilot wants to merge 2 commits into
Conversation
Co-authored-by: rmarinho <1235097+rmarinho@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add AdbRunner.EnrichDeviceAsync to populate device information
Add Jun 2, 2026
AdbRunner.EnrichDeviceAsync to populate device metadata via getprop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adb devices -ldoes not provide enough metadata for downstream device selection flows (architecture, manufacturer, Android version/SDK). This change adds a canonical opt-in enrichment API inAdbRunnerso consumers can stop re-implementing per-devicegetproporchestration.API surface: richer
AdbDeviceInfoCpuAbiManufacturerReleaseVersionSdkVersionnetstandard2.0andnet10.0.AdbRunnerenrichment APIEnrichDeviceAsync(AdbDeviceInfo device, CancellationToken cancellationToken = default).device.Status != Online.adb shell getpropin parallel.ro.product.cpu.abilist(first entry) →ro.product.cpu.abiro.product.manufacturer→ro.product.brandro.product.modelro.build.version.releasero.build.version.sdkTargeted coverage for new behavior