Restructure the project for consistency with xamarin-android#5
Merged
dellis1972 merged 1 commit intodotnet:masterfrom Sep 7, 2017
Merged
Restructure the project for consistency with xamarin-android#5dellis1972 merged 1 commit intodotnet:masterfrom
dellis1972 merged 1 commit intodotnet:masterfrom
Conversation
jonpryor
force-pushed
the
jonp-dir-structure
branch
3 times, most recently
from
dcc7046 to
b3f892c
Compare
dellis1972
requested changes
Sep 7, 2017
Makefile
Outdated
| # $(call RUN_NUNIT_TEST,filename,log-lref?) | ||
| define RUN_NUNIT_TEST | ||
| MONO_TRACE_LISTENER=Console.Out \ | ||
| $(RUNTIME) --runtime=v4.0.0 \ |
Contributor
There was a problem hiding this comment.
should this not just be v4.0 ? Not sure what windows will do with v4.0.0
Contributor
Author
There was a problem hiding this comment.
It's different/worse from that: --runtime is a mono option, and if mono is not used, there will thus be no command at all, which is bad.
On the ¯_(ツ)_/¯ side, this is what xamarin-android does...
I'll remove the --runtime option. It might not be needed anymore now that I'm using NUnit 3.2.1.
Contributor
There was a problem hiding this comment.
I think the newer NUnit does a better job at detecting mono.
Contributor
There was a problem hiding this comment.
I tend to use the --framework option though..
`Xamarin.Android.sln` is now a toplevel file, so it's easier to see
without navigating into the `src` directory.
Add a `Makefile` with three targets of consequence:
* `make prepare`: Prepare the project for building, e.g.
restore NuGet packages.
* `make all`: Build the project.
* `make run-all-tests`: Run the NUnit tests.
Update to use NUnit 3.2.1 packages.
Update `README.md` with build instructions.
Add a `LICENSE` file.
Rename `Xamarin.Android.Tools.dll` to
`Xamarin.Android.Tools.AndroidSdk.dll`. Xamarin.Android already has
multiple `Xamarin.Android.Tools.*.dll` assemblies, e.g.
`Xamarin.Android.Tools.BootstrapTasks.dll`. Naming-wise,
`Xamarin.Android.Tools.dll` sounds like it should be *core* to *all*
related assemblies, but it isn't, and won't be. Instead, its core
responsibility is around the Android SDK, so name it accordingly.
Move unit tests for `Xamarin.Android.Tools.AndroidSdk` into
`src/Xamarin.Android.Tools.AndroidSdk/Tests` (child, not a peer).
Rename the unit test assembly to
`Xamarin.Android.Tools.AndroidSdk-Tests.dll`, and build into
`bin/Test$(Configuration)`.
jonpryor
force-pushed
the
jonp-dir-structure
branch
from
b3f892c to
a95430d
Compare
dellis1972
approved these changes
Sep 7, 2017
rmarinho
added a commit
that referenced
this pull request
Mar 13, 2026
Fix #1: Validate avdName in LaunchAvd (ArgumentException on null/empty) Fix #2: RunShellCommandAsync now returns full trimmed stdout (not just first line) Fix #3: Add 9 FirstNonEmptyLine parsing tests + 3 LaunchAvd validation tests Fix #5: Log stderr via logger on shell command failures (AdbRunner gets logger param) Fix #6: Remove TOCTOU HasExited check in TryKillProcess (rely on catch block) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rmarinho
added a commit
that referenced
this pull request
Mar 13, 2026
Fix #1: Validate avdName in LaunchAvd (ArgumentException on null/empty) Fix #2: RunShellCommandAsync now returns full trimmed stdout (not just first line) Fix #3: Add 9 FirstNonEmptyLine parsing tests + 3 LaunchAvd validation tests Fix #5: Log stderr via logger on shell command failures (AdbRunner gets logger param) Fix #6: Remove TOCTOU HasExited check in TryKillProcess (rely on catch block) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xamarin.Android.slnis now a toplevel file, so it's easier to seewithout navigating into the
srcdirectory.Add a
Makefilewith three targets of consequence:make prepare: Prepare the project for building, e.g.restore NuGet packages.
make all: Build the project.make run-all-tests: Run the NUnit tests.Move unit tests for
Xamarin.Android.Toolsintosrc/Xamarin.Android.Tools/Tests(child, not a peer).Rename the unit test assembly to
Xamarin.Android.Tools-Tests.dll,and build into
bin/Test$(Configuration).Update to use NUnit 3.2.1 packages.
Update
README.mdwith build instructions.Add a
LICENSEfile.Rename
Xamarin.Android.Tools.dlltoXamarin.Android.Tools.AndroidSdk.dll. Xamarin.Android already hasmultiple
Xamarin.Android.Tools.*.dllassemblies, e.g.Xamarin.Android.Tools.BootstrapTasks.dll. Naming-wise,Xamarin.Android.Tools.dllsounds like it should be core to allrelated assemblies, but it isn't, and won't be. Instead, its core
responsibility is around the Android SDK, so name it accordingly.