Merged
Conversation
This checks for /System/Library/Java/JavaVirtualMachines if we're trying to use the system java. If there is no system Java installed then calling /usr/bin/java has the unfortunate effect of popping up a dialog telling the user to install a JDK. Fixes VSTS #735545
|
@jonpryor thoughts? this is associated with a blocker bug on VSM. |
|
@monojenkins backport d15-9 |
Contributor
|
@monojenkins backport d15-9 |
jonpryor
pushed a commit
that referenced
this pull request
Dec 11, 2018
Fixes: http://work.devdiv.io/735545 When Visual Studio for Mac is installed on a "clean" machine which doesn't have a Java installed, two dialog boxes about Java are shown when launching Visual Studio for Mac: > To use the "java" command-line tool you need to install a JDK. This happens because `java` is found via `$PATH` (`JdkInfo.GetPathEnvironmentJdkPaths()`) -- because `/usr/bin/java` exists -- but the `java` which is available is "bad", because executing `java` results in the aforementioned dialog box. Avoid calling `java` from `JdkInfo.GetPathEnvironmentJdkPaths()` by introducing a macOS-specific check *requiring* that `/System/Library/Java/JavaVirtualMachines` both *exist* and contain *sub-directories* before `/usr/bin/java` or `java` are executed.
Contributor
Author
Contributor
Author
|
@monojenkins backport d16-0 |
jonpryor
pushed a commit
that referenced
this pull request
Dec 12, 2018
Fixes: http://work.devdiv.io/735545 When Visual Studio for Mac is installed on a "clean" machine which doesn't have a Java installed, two dialog boxes about Java are shown when launching Visual Studio for Mac: > To use the "java" command-line tool you need to install a JDK. This happens because `java` is found via `$PATH` (`JdkInfo.GetPathEnvironmentJdkPaths()`) -- because `/usr/bin/java` exists -- but the `java` which is available is "bad", because executing `java` results in the aforementioned dialog box. Avoid calling `java` from `JdkInfo.GetPathEnvironmentJdkPaths()` by introducing a macOS-specific check *requiring* that `/System/Library/Java/JavaVirtualMachines` both *exist* and contain *sub-directories* before `/usr/bin/java` or `java` are executed.
jonathanpeppers
added a commit
that referenced
this pull request
Mar 4, 2026
New findings: - `#52`: Never use null-forgiving operator (!) - `#53`: Add overloads to reduce caller ceremony - `#54`: Delete unused overloads - `#55`: Prefer C# pattern matching - `#56`: Section-separator comments are `#region` in disguise Updated `review-rules.md`: extended `#region` ban to cover banner comments, added null-forgiving `!` as AI anti-pattern, added overload and pattern matching rules to API Design section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks for /System/Library/Java/JavaVirtualMachines if we're
trying to use the system java. If there is no system Java installed
then calling /usr/bin/java has the unfortunate effect of popping up
a dialog telling the user to install a JDK.
Fixes VSTS #735545
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/735545