[xabt] pass in $(SupportedOSPlatformVersion) to <Aapt2Link/>
#10538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #10194 Context: https://discord.com/channels/732297728826277939/732297837953679412/1427681737957441577 Fixes: #6739 PR #10194 was originally meant to fix #6739, but did not when testing a sample project. The test written in #10194 passed even without the fixes, so we did not have a proper test case. After reviewing the failing project, I noticed `<Aapt2Link/>` was passed: AndroidManifestFile = D:\Downloads\test_sdk26\AndroidManifest.xml This is the developer's `AndroidManifest.xml` in their project, which should completely omit `<uses-sdk/>` in favor of the `$(SupportedOSPlatformVersion)` MSBuild property. I suspect the fix for #10194 would have worked if `<uses-sdk/>` was present. `<Aapt2Link/>` can run quite early, before we have generated the final `AndroidManifest.xml` file. So, a solution here is to pass in `$(SupportedOSPlatformVersion)` to `<Aapt2Link/>`. I also updated the test so it properly tests this scenario.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
approved these changes
Oct 16, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Oct 16, 2025
) Context: #10194 Context: https://discord.com/channels/732297728826277939/732297837953679412/1427681737957441577 Fixes: #6739 PR #10194 was originally meant to fix #6739, but did not when testing a sample project. The test written in #10194 passed even without the fixes, so we did not have a proper test case. After reviewing the failing project, I noticed `<Aapt2Link/>` was passed: AndroidManifestFile = D:\Downloads\test_sdk26\AndroidManifest.xml This is the developer's `AndroidManifest.xml` in their project, which should completely omit `<uses-sdk/>` in favor of the `$(SupportedOSPlatformVersion)` MSBuild property. I suspect the fix for #10194 would have worked if `<uses-sdk/>` was present. `<Aapt2Link/>` can run quite early, before we have generated the final `AndroidManifest.xml` file. So, a solution here is to pass in `$(SupportedOSPlatformVersion)` to `<Aapt2Link/>`. I also updated the test so it properly tests this scenario.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #10194
Context: https://discord.com/channels/732297728826277939/732297837953679412/1427681737957441577
Fixes: #6739
PR #10194 was originally meant to fix #6739, but did not when testing a sample project. The test written in #10194 passed even without the fixes, so we did not have a proper test case.
After reviewing the failing project, I noticed
<Aapt2Link/>was passed:This is the developer's
AndroidManifest.xmlin their project, which should completely omit<uses-sdk/>in favor of the$(SupportedOSPlatformVersion)MSBuild property. I suspect the fix for #10194 would have worked if<uses-sdk/>was present.<Aapt2Link/>can run quite early, before we have generated the finalAndroidManifest.xmlfile. So, a solution here is to pass in$(SupportedOSPlatformVersion)to<Aapt2Link/>.I also updated the test so it properly tests this scenario.