Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
JavaPlatformJarPath="$(JavaPlatformJarPath)"
JavaDesignerOutputDirectory="$(ResgenTemporaryDirectory)"
CompiledResourceFlatFiles="@(_CompiledFlatFiles)"
SupportedOSPlatformVersion="$(SupportedOSPlatformVersion)"
AndroidManifestFile="$(_AndroidManifestAbs)"
ManifestFiles="$(ResgenTemporaryDirectory)\AndroidManifest.xml"
AdditionalAndroidResourcePaths="@(_LibraryResourceDirectories)"
Expand Down Expand Up @@ -213,6 +214,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
</PropertyGroup>
<MakeDir Directories="$(_OutputFileDir)" Condition=" !Exists ('$(_OutputFileDir)') " />
<Aapt2Link
SupportedOSPlatformVersion="$(SupportedOSPlatformVersion)"
AndroidManifestFile="$(_AndroidManifestAbs)"
CompiledResourceFlatFiles="@(_CompiledFlatFiles)"
DaemonMaxInstanceCount="$(Aapt2DaemonMaxInstanceCount)"
Expand Down
4 changes: 3 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/Aapt2.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ public abstract class Aapt2 : AsyncTask {

public ITaskItem []? ResourceDirectories { get; set; }

public ITaskItem? AndroidManifestFile { get; set;}
public ITaskItem? AndroidManifestFile { get; set; }

public string? SupportedOSPlatformVersion { get; set; }

public string? ResourceSymbolsTextFile { get; set; }

Expand Down
17 changes: 11 additions & 6 deletions src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Link.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@
#nullable enable

using System;
using System.Diagnostics;
using System.IO;
using System.Globalization;
using System.Linq;
using System.Text;
using System.Threading;
using System.Xml;
using System.Xml.Linq;
using Microsoft.Build.Utilities;
using Microsoft.Build.Framework;
using System.Text.RegularExpressions;
Expand Down Expand Up @@ -322,13 +319,21 @@ string [] GenerateCommandLineCommands (string ManifestFile, string? currentAbi,
cmd.Add (GetFullPath (currentResourceOutputFile));

// Add min SDK version from AndroidManifestFile if available
string? minSdkVersion = null;
if (AndroidManifestFile is { ItemSpec.Length: > 0 }) {
var doc = AndroidAppManifest.Load (AndroidManifestFile.ItemSpec, MonoAndroidHelper.SupportedVersions);
if (doc.MinSdkVersion.HasValue) {
cmd.Add ("--min-sdk-version");
cmd.Add (doc.MinSdkVersion.Value.ToString ());
minSdkVersion = doc.MinSdkVersion.Value.ToString (CultureInfo.InvariantCulture);
}
}
// Use $(SupportedOSPlatformVersion) if minSdkVersion was not found in the manifest
if (minSdkVersion.IsNullOrEmpty () && MonoAndroidHelper.TryParseApiLevel (SupportedOSPlatformVersion, out Version version)) {
minSdkVersion = version.Major.ToString (CultureInfo.InvariantCulture);
}
if (!minSdkVersion.IsNullOrEmpty ()) {
cmd.Add ("--min-sdk-version");
cmd.Add (minSdkVersion);
}

return cmd.ToArray ();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.IO;
using System.Linq;
using Microsoft.Build.Framework;
using System.Text;
using Xamarin.Android.Tasks;
using Microsoft.Build.Utilities;

Expand Down Expand Up @@ -162,6 +161,22 @@ public void AdaptiveIcon ()
var proj = new XamarinAndroidApplicationProject {
SupportedOSPlatformVersion = "26",
AndroidResources = {
new AndroidItem.AndroidResource ("Resources\\values\\colors.xml") {
TextContent = () => """
<resources>
<color name="adaptive_icon_background">#2C3E50</color>
<color name="adaptive_icon_foreground">#FFFFFF</color>
</resources>
""",
},
new AndroidItem.AndroidResource ("Resources\\drawable\\ic_shortcut_add.xml") {
TextContent = () => """
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@color/adaptive_icon_background"/>
<foreground android:drawable="@color/adaptive_icon_foreground"/>
</adaptive-icon>
""",
},
new AndroidItem.AndroidResource ("Resources\\mipmap-anydpi-v26\\adaptiveicon.xml") {
TextContent = () => """
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
Expand Down
14 changes: 14 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Utilities/MonoAndroidHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,20 @@ public static int ConvertSupportedOSPlatformVersionToApiLevel (string version)
return apiLevel;
}

public static bool TryParseApiLevel (string apiLevel, out Version version)
{
if (Version.TryParse (apiLevel, out var v)) {
version = v;
return true;
}
if (int.TryParse (apiLevel, out var major)) {
version = new Version (major, 0);
return true;
}
version = null;
return false;
}

#if MSBUILD
public static string GetAssemblyAbi (ITaskItem asmItem)
{
Expand Down
Loading