Rename assembly stores in the APK/AAB archive to libassembly-store.so
#10638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #10634 Amazon application store appears to verify the uploaded archives by, among other steps, comparing names of libraries packaged into per-ABI `lib/` directories. If it finds library names that don't correspond to entries in any of the other `lib/{ABI}` directories, it decides that the application is incorrectly constructed and rejects the upload. In our case the check failed because of names of the assembly store files in the archive which are named `libassemblies.{ABI}.blob.so` and, thus, would have unique entries in every `lib/{ABI}/` directory. This is an artifact from the time where all stores were placed in a single directory (`assemblies/`) and had to have distinct names in order for that to work. The Amazon store check, in this regard, is just an unnecessary obstacle (since there's no reason, technical or otherwise, for different ABIs to have identical sets of libraries), but since a we have no way to fix it other than to comply with the Amazon store requirements and, this PR renames assembly store files to have a uniform name across all the ABIs present in the application: `libassembly-store.so`
grendello
force-pushed
the
dev/grendel/assembly-stores-name
branch
from
08dad03 to
11d2440
Compare
There was a problem hiding this comment.
Pull request overview
This PR renames assembly store files from libassemblies.{ABI}.blob.so to a uniform libassembly-store.so across all ABIs to comply with Amazon App Store requirements. Amazon's validation rejects archives where library names in lib/{ABI}/ directories don't match across different ABIs, which was the case with the old ABI-specific naming scheme.
Key changes:
- Unified assembly store filename to
libassembly-store.soacross all ABIs - Updated C# build tasks and tools to generate and read the new filename
- Updated C++ native code constants to use the new filename
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Utilities/AssemblyStoreGenerator.cs | Updated to generate assembly stores with new uniform name (contains path construction bug) |
| tools/assembly-store-reader-mk2/AssemblyStore/StoreReader_V2.cs | Updated to read assembly stores with new uniform name |
| tools/assembly-store-reader-mk2/Main.cs | Updated help text to reflect new naming convention (contains documentation error) |
| src/native/mono/monodroid/embedded-assemblies.hh | Updated constant definitions to use new uniform filename |
| src/native/clr/include/constants.hh | Updated constant definitions to use new uniform filename |
| src/Xamarin.Android.Build.Tasks/Tasks/CreateAssemblyStore.cs | Updated documentation comment to be more generic |
| src/Xamarin.Android.Build.Tasks/Tasks/CollectRuntimeConfigFilesForArchive.cs | Updated comment to reference new filename |
| Documentation/project-docs/ApkSharedLibraries.md | Updated examples to use new filename |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64XFormsDotNet.CoreCLR.apkdesc | Updated test baseline for new filename |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64SimpleDotNet.CoreCLR.apkdesc | Updated test baseline for new filename |
src/Xamarin.Android.Build.Tasks/Utilities/AssemblyStoreGenerator.cs
Outdated
Show resolved
Hide resolved
…or.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jonathanpeppers
approved these changes
Dec 10, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
We can ignore the one test failure:
jonathanpeppers
pushed a commit
that referenced
this pull request
Dec 10, 2025
…o` (#10638) Fixes: #10634 Amazon application store appears to verify the uploaded archives by, among other steps, comparing names of libraries packaged into per-ABI `lib/` directories. If it finds library names that don't correspond to entries in any of the other `lib/{ABI}` directories, it decides that the application is incorrectly constructed and rejects the upload. In our case the check failed because of names of the assembly store files in the archive which are named `libassemblies.{ABI}.blob.so` and, thus, would have unique entries in every `lib/{ABI}/` directory. This is an artifact from the time where all stores were placed in a single directory (`assemblies/`) and had to have distinct names in order for that to work. The Amazon store check, in this regard, is just an unnecessary obstacle (since there's no reason, technical or otherwise, for different ABIs to have identical sets of libraries), but since a we have no way to fix it other than to comply with the Amazon store requirements and, this PR renames assembly store files to have a uniform name across all the ABIs present in the application: `libassembly-store.so`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10634
Amazon application store appears to verify the uploaded archives by, among other steps, comparing names of libraries packaged into per-ABI
lib/directories. If it finds library names that don't correspond to entries in any of the otherlib/{ABI}directories, it decides that the application is incorrectly constructed and rejects the upload.In our case the check failed because of names of the assembly store files in the archive which are named
libassemblies.{ABI}.blob.soand, thus, would have unique entries in everylib/{ABI}/directory. This is an artifact from the time where all stores were placed in a single directory (assemblies/) and had to have distinct names in order for that to work.The Amazon store check, in this regard, is just an unnecessary obstacle (since there's no reason, technical or otherwise, for different ABIs to have identical sets of libraries), but since a we have no way to fix it other than to comply with the Amazon store requirements and, this PR renames assembly store files to have a uniform name across all the ABIs present in the application:
libassembly-store.so