[xabt] support @(RuntimeEnvironmentVariable) items#10770
Draft
jonathanpeppers wants to merge 1 commit intomainfrom
Draft
[xabt] support @(RuntimeEnvironmentVariable) items#10770jonathanpeppers wants to merge 1 commit intomainfrom
@(RuntimeEnvironmentVariable) items#10770jonathanpeppers wants to merge 1 commit intomainfrom
Conversation
Context: dotnet/sdk@bd5d3af `dotnet run` now passes in `dotnet run -e FOO=BAR` as `@(RuntimeEnvironmentVariable)` MSBuild items. To opt in to this new feature, we need to add: <ProjectCapability Include="RuntimeEnvironmentVariableSupport" /> As well as update the `_GenerateEnvironmentFiles` MSBuild target: <!-- RuntimeEnvironmentVariable items come from 'dotnet run -e NAME=VALUE' --> <_GeneratedAndroidEnvironment Include="@(RuntimeEnvironmentVariable->'%(Identity)=%(Value)')" /> I added a new test to verify we have the env vars on-device at runtime. Note that I tested this in combination with a local .NET SDK build: * #10769 We won't be able to merge this until we have a .NET SDK here that includes the above commit.
51 tasks
jonathanpeppers
added
the
copilot
Member
Author
|
This is waiting on a .NET SDK that has the change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/sdk@bd5d3af
dotnet runnow passes indotnet run -e FOO=BARas@(RuntimeEnvironmentVariable)MSBuild items.To opt in to this new feature, we need to add:
As well as update the
_GenerateEnvironmentFilesMSBuild target:I added a new test to verify we have the env vars on-device at runtime.
Note that I tested this in combination with a local .NET SDK build:
--dotnet-sdk-archiveswitch #10769We won't be able to merge this until we have a .NET SDK here that includes the above commit.