Skip to content

Use Assert.Inconclusive for emulator acquisition failures #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 4 commits into from
Apr 15, 2026
Merged

Use Assert.Inconclusive for emulator acquisition failures #11110

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d8ba0
Use Assert.Inconclusive for emulator acquisition failures
jonathanpeppers Apr 14, 2026
5cab7b6
Only Assert.Inconclusive for known transient emulator errors
jonathanpeppers Apr 14, 2026
64aeecf
Use case-insensitive string comparison for error patterns
jonathanpeppers Apr 14, 2026
89d165f
Iterate lines instead of joining into one large string
jonathanpeppers Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,16 @@ public static void RestartDevice ()
// shell out to msbuild and start the emulator again
var dotnet = new DotNetCLI (Path.Combine (XABuildPaths.TopDirectory, "src", "Xamarin.Android.Build.Tasks", "Tests", "Xamarin.Android.Build.Tests", "Emulator.csproj"));
dotnet.ProjectDirectory = XABuildPaths.TestAssemblyOutputDirectory;
Assert.IsTrue (dotnet.Build ("AcquireAndroidTarget", parameters: new string[] { "TestAvdForceCreation=false", $"Configuration={XABuildPaths.Configuration}" }), "Failed to acquire emulator.");
if (!dotnet.Build ("AcquireAndroidTarget", parameters: new string[] { "TestAvdForceCreation=false", $"Configuration={XABuildPaths.Configuration}" })) {
bool isTransient = dotnet.LastBuildOutput.Any (line =>
line.Contains ("did not finish launching", StringComparison.OrdinalIgnoreCase) ||
line.Contains ("Emulator failed to start", StringComparison.OrdinalIgnoreCase) ||
line.Contains ("failed to exit within the timeout", StringComparison.OrdinalIgnoreCase));
if (isTransient) {
Assert.Inconclusive ("Failed to acquire emulator due to transient infrastructure issue.");
}
Assert.Fail ("Failed to acquire emulator.");
}
Comment thread
jonathanpeppers marked this conversation as resolved.
WaitFor ((int)TimeSpan.FromSeconds (5).TotalMilliseconds);
}

Expand Down