Skip to content

Make CoreCLR the default runtime for Debug builds #11169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 8 commits into from
Apr 22, 2026
+15 −6
Merged

Make CoreCLR the default runtime for Debug builds #11169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0196ae6
Make CoreCLR the default runtime for Debug builds
simonrozsival Apr 21, 2026
7d615b0
Set EmbedAssembliesIntoApk=true in androidtest template
simonrozsival Apr 21, 2026
01d8b4e
[TrimmableTypeMap] Fix UCO boolean return type mismatch causing n_* c…
simonrozsival Apr 21, 2026
a858858
Parameterize DotNetNewAndroidTest for MonoVM and CoreCLR
jonathanpeppers Apr 21, 2026
efc213e
Merge branch 'main' into dev/simonrozsival/coreclr-default-for-debug
jonathanpeppers Apr 21, 2026
c6d06ac
Revert "Set EmbedAssembliesIntoApk=true in androidtest template"
jonathanpeppers Apr 21, 2026
cf6d4e1
Fix StartRun parameters need /p: prefix
jonathanpeppers Apr 21, 2026
e7125be
Skip DotNetNewAndroidTest(CoreCLR) until MSTest fixes Assembly.Location
jonathanpeppers Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
<_AndroidFastDeploymentSupported Condition=" Exists ('$(MSBuildThisFileDirectory)../tools/Xamarin.Android.Common.Debugging.targets') ">true</_AndroidFastDeploymentSupported>
<_AndroidFastDeploymentSupported Condition=" '$(_AndroidFastDeploymentSupported)' == '' ">False</_AndroidFastDeploymentSupported>

<!-- TODO: remove when we have debugger support for CoreCLR -->
<UseMonoRuntime Condition=" '$(UseMonoRuntime)' == '' and '$(Configuration)' == 'Debug' ">true</UseMonoRuntime>

<!--
Disable @(Content) from referenced projects
See: https://github.com/dotnet/sdk/blob/955c0fc7b06e2fa34bacd076ed39f61e4fb61716/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets#L16
Expand Down
18 changes: 15 additions & 3 deletions tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2233,7 +2233,9 @@ public void StartAndroidActivityRespectsAndroidDeviceUserId ()
}

[Test]
public void DotNetNewAndroidTest ()
[TestCase (AndroidRuntime.MonoVM)]
[TestCase (AndroidRuntime.CoreCLR)]
public void DotNetNewAndroidTest (AndroidRuntime runtime)
{
var templateName = TestName;
var projectDirectory = Path.Combine (Root, "temp", templateName);
Expand All @@ -2244,12 +2246,22 @@ public void DotNetNewAndroidTest ()
var dotnet = new DotNetCLI (Path.Combine (projectDirectory, $"{templateName}.csproj"));
Assert.IsTrue (dotnet.New ("androidtest"), "`dotnet new androidtest` should succeed");

bool useMonoRuntime = runtime == AndroidRuntime.MonoVM;
var buildParameters = new List<string> {
$"UseMonoRuntime={useMonoRuntime}",
};

if (runtime == AndroidRuntime.CoreCLR) {
Assert.Ignore ("https://github.com/dotnet/android/issues/11174");
}
Comment on lines +2249 to +2256
Copy link
Copy Markdown
Member

@jonathanpeppers jonathanpeppers Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the CoreCLR test fails:

Image

Copy link
Copy Markdown
Member

@jonathanpeppers jonathanpeppers Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm:

Copy link
Copy Markdown
Member Author

@simonrozsival simonrozsival Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/testfx#7769

Copy link
Copy Markdown
Member Author

@simonrozsival simonrozsival Apr 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR that will fix this looks solid: microsoft/testfx#7772


// Build and assert 0 warnings
Assert.IsTrue (dotnet.Build (), "`dotnet build` should succeed");
Assert.IsTrue (dotnet.Build (parameters: buildParameters.ToArray ()), "`dotnet build` should succeed");
dotnet.AssertHasNoWarnings ();

// Run instrumentation via `dotnet run` and capture output
using var process = dotnet.StartRun (waitForExit: true);
var runParameters = buildParameters.Select (p => $"/p:{p}").ToArray ();
using var process = dotnet.StartRun (waitForExit: true, parameters: runParameters);

var locker = new Lock ();
var output = new StringBuilder ();
Expand Down