Skip to content

Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments#11377

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-logfailure-in-nativelinker
Draft

Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments#11377
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-logfailure-in-nativelinker

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

LogFailure in NativeLinker.ExtractDebugSymbols called log.LogError("Failed to extract debug info", filename, output) — a format string with no placeholders, so the library name and command output were silently dropped. Also lacked an error code and used LogError for a non-fatal condition (debug symbol extraction after successful linking).

Changes:

  • Add XA3008 resource string to Resources.resx / Resources.Designer.cs
  • Replace LogError with LogCodedWarning("XA3008", ...) using proper format placeholders
  • Remove resolved TODO comments
  • Add Documentation/docs-mobile/messages/xa3008.md and index entry
// Before: format args silently ignored
log.LogError ("Failed to extract debug info", Path.GetFileName (sourceLib), sb.ToString ());

// After: args properly interpolated into coded warning
log.LogCodedWarning ("XA3008", Properties.Resources.XA3008, Path.GetFileName (sourceLib), sb.ToString ());

…uments

- Add XA3008 resource string to Resources.resx and Resources.Designer.cs
- Replace LogError with LogCodedWarning using proper format placeholders
- Remove resolved TODO comments
- Add documentation at Documentation/docs-mobile/messages/xa3008.md
- Add XA3008 to message index

Agent-Logs-Url: https://github.com/dotnet/android/sessions/bc30af09-6939-40cd-b8ad-c12a52ac522d

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix LogFailure to include format arguments and error code Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments May 15, 2026
Copilot AI requested a review from jonathanpeppers May 15, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] NativeLinker.cs: LogFailure drops format arguments and lacks error code

2 participants