Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments#11377
Draft
Copilot wants to merge 2 commits into
Draft
Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments#11377Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
9 tasks
…uments - Add XA3008 resource string to Resources.resx and Resources.Designer.cs - Replace LogError with LogCodedWarning using proper format placeholders - Remove resolved TODO comments - Add documentation at Documentation/docs-mobile/messages/xa3008.md - Add XA3008 to message index Agent-Logs-Url: https://github.com/dotnet/android/sessions/bc30af09-6939-40cd-b8ad-c12a52ac522d Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix LogFailure to include format arguments and error code
Fix NativeLinker.LogFailure: add XA3008 coded warning with format arguments
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogFailureinNativeLinker.ExtractDebugSymbolscalledlog.LogError("Failed to extract debug info", filename, output)— a format string with no placeholders, so the library name and command output were silently dropped. Also lacked an error code and usedLogErrorfor a non-fatal condition (debug symbol extraction after successful linking).Changes:
XA3008resource string toResources.resx/Resources.Designer.csLogErrorwithLogCodedWarning("XA3008", ...)using proper format placeholdersDocumentation/docs-mobile/messages/xa3008.mdand index entry