Move hardcoded error string in CompressAssemblies to Properties.Resources with XA5303 error code#11417
Draft
Copilot wants to merge 2 commits into
Draft
Move hardcoded error string in CompressAssemblies to Properties.Resources with XA5303 error code#11417Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
8 tasks
…rces with XA5303 error code Agent-Logs-Url: https://github.com/dotnet/android/sessions/52c93f42-0059-4961-9f1e-0f721c9cc505 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix hardcoded error string in CompressAssemblies to use resources
Move hardcoded error string in CompressAssemblies to Properties.Resources with XA5303 error code
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompressAssemblies.csuses a hardcodedLog.LogError()string for theDescriptorIndexparse failure, making it non-localizable and missing a proper error code.Changes
Properties/Resources.resx/Resources.Designer.cs: AddXA5303resource stringCompressAssemblies.cs: ReplaceLog.LogError(...)withLog.LogCodedError("XA5303", ...)Documentation/docs-mobile/messages/xa5303.md: New error documentationDocumentation/docs-mobile/messages/index.md: AddXA5303to index