[Trimming] Propagate GetObject constructor annotations#11437
Draft
simonrozsival wants to merge 1 commit into
Draft
[Trimming] Propagate GetObject constructor annotations#11437simonrozsival wants to merge 1 commit into
simonrozsival wants to merge 1 commit into
Conversation
Annotate the GetObject generic type parameters and Type argument so constructor DAM requirements flow through to JniValueManager.GetPeer(). Remove the local UnconditionalSuppressMessage helper now that the requirement is represented at the call sites. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves trimming safety in Mono.Android by propagating constructor DynamicallyAccessedMembers (DAM) annotations through the Java.Lang.Object.GetObject* APIs, allowing JniValueManager.GetPeer() to be called directly without requiring a local suppression helper.
Changes:
- Added
[DynamicallyAccessedMembers (Constructors)]annotations to the genericGetObject<T>/_GetObject<T>type parameters. - Annotated the internal
GetObject(IntPtr, JniHandleOwnership, Type?)typeparameter and removed the localUnconditionalSuppressMessagewrapper. - Switched to a direct call to
JniEnvironment.Runtime.ValueManager.GetPeer(...).
simonrozsival
changed the title
Member
|
Something broke: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Java.Lang.Object.GetObjectJniValueManager.GetPeer()directly now that theTypeparameter is annotatedUnconditionalSuppressMessagehelper aroundGetPeer()Part of #10794.
Validation
git diff --checkdotnet restore src/Mono.Android/Mono.Android.csproj -v:minimaldotnet build src/Mono.Android/Mono.Android.csproj --no-restore -v:minimal(fails before compiling Mono.Android because this isolated worktree lacksexternal/Java.Interop/src/Xamarin.Android.Tools.ApiXmlAdjuster, andjava-runtimelater reports an environment command issue)