Skip to content

[ci] Android PR Reviewer: restrict to COMMENT events only#11762

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-curly-system
Jun 27, 2026
Merged

[ci] Android PR Reviewer: restrict to COMMENT events only#11762
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-curly-system

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

The Android PR Reviewer workflow was allowed to submit REQUEST_CHANGES reviews, which block PRs and require a maintainer to manually dismiss the review (as just happened on #11758). The reviewer is an advisory bot — its findings should surface as comments, not as a merge blocker.

This removes REQUEST_CHANGES from allowed-events in .github/workflows/android-reviewer.md so the workflow can only submit COMMENT reviews, and updates the instruction line accordingly. The generated .lock.yml is updated to match.

No behavior change for clean PRs; "needs changes" findings will now appear as a comment-style review instead of a changes-requested review.

Remove REQUEST_CHANGES from allowed-events so the reviewer workflow can only post comments, not block PRs by requesting changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 26, 2026 18:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android PR Reviewer workflow configuration so it can only submit COMMENT reviews (never REQUEST_CHANGES), preventing the bot from blocking PRs while still surfacing findings as advisory feedback.

Changes:

  • Restricts submit-pull-request-review allowed-events to [COMMENT] in the workflow definition.
  • Updates the reviewer instruction text to explicitly prohibit APPROVE and REQUEST_CHANGES.
  • Regenerates the corresponding .lock.yml so the safe-outputs configuration matches the new restriction.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/android-reviewer.md Limits review submission events to COMMENT and updates instructions accordingly.
.github/workflows/android-reviewer.lock.yml Updates generated safe-outputs configs to only allow COMMENT events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants