Bump mono to mono-4.8.0-branch commit 8864f4c and install Mono.Btls.Interface#283
Merged
Bump mono to mono-4.8.0-branch commit 8864f4c and install Mono.Btls.Interface#283
Conversation
radical
pushed a commit
that referenced
this pull request
May 8, 2018
In revisiting the unit tests throughout Java.Interop, I found it a
good idea to upgrade to NUnit 3.x:
- The current version, 2.6.3, is fairly ancient from circa 2013
- We could get on the same version as `xamarin-android`
- NUnit 3.x has a wider range of assertion APIs
- If we are on NUnit >3.5, we can take advantage of the "live unit
testing" feature on VS for Windows
~~ Changes ~~
Updated NuGet packages to match `xamarin-android`:
- NUnit 2.6.3 -> NUnit 3.7.1
- NUnit.Runners 2.6.3 -> NUnit.Console 3.7.0
- NUnit.Console's various dependencies
Fixes in tests:
- `[ExpectedException]` is removed in NUnit, ported all usage to
`Assert.Throws<T>`
- NUnit 3 purposely changed the behavior of the current directory (tests
shouldn't use it!) fixed the following that used the current directory:
- `generator-Tests` throughout the project
- `TypeNameMapGeneratorTests`
- `JavaCallableWrapperGeneratorTests`
- `MarshalMemberBuilderTests`
- `TestJVM`
- `JAVA_INTEROP_GREF_LOG` and `JAVA_INTEROP_LREF_LOG`
- `generator` had one place where `Directory.CreateDirectory()` was needed
prior to opening a file, if the directory did not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.