[Xamarin.Android.Build.Tasks] Avoid stack overflow in ResolveAssemblies.#284
Merged
[Xamarin.Android.Build.Tasks] Avoid stack overflow in ResolveAssemblies.#284
Conversation
Use the same Path.GetFullPath() in .Contains() and .Add().
radical
pushed a commit
that referenced
this pull request
May 8, 2018
As I begin refactoring `generator`, it looks like I will be making
changes to `ManagedClassGen` and `XmlClassGen` as well as the various
other types that use either Mono.Cecil or `XDocument` to represent a
type in `generator`.
These are the first examples of unit tests that can be written against
these classes, and are just simple smoke tests for now.
ManagedTests:
- C# types defined in a namespace at the top of the file
- Copies current test assembly to `%TEMP%` & load via Mono.Cecil
- Mono.Cecil holds a lock on the file, so it was causing some
issues with my IDE if I opened the current assembly with Cecil
- Had to change the build action for `SupportFiles\RegisterAttribute` so
I could use the type within the test assembly. It is still copied to the
output directory for the integration tests.
- Implemented a missing `ctor` for `RegisterAttribute` that was throwing
`NotImplementedException`
XmlTests:
- Defined XML at the top of the file
- Use `System.Xml.Linq` to load specific elements as needed
Various smoke tests for:
- Classes
- Methods
- Parameters
- Fields
- Interfaces
In the future, I may need to expand on these tests to make sure I
don't break things. They may also get refactored/removed one day if
we get the classes under test refactored to POCOs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same Path.GetFullPath() in .Contains() and .Add().