Skip to content

use ant version 1.9.8 as 1.9.7 is no longer available at ibiblio#345

Merged
jonpryor merged 1 commit intodotnet:masterfrom
radekdoulik:bump-ant-version
Jan 4, 2017
Merged

use ant version 1.9.8 as 1.9.7 is no longer available at ibiblio#345
jonpryor merged 1 commit intodotnet:masterfrom
radekdoulik:bump-ant-version

Conversation

@radekdoulik
Copy link
Copy Markdown
Member

No description provided.

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

The fix is good, but the PR builder isn't building it. It looks like a Cecil mismatch:

LocationProvider.cs(75,16): error CS1061: Type `Mono.Cecil.MethodDefinition' does not contain a definition for `DebugInformation' and no extension method `DebugInformation' of type `Mono.Cecil.MethodDefinition' could be found. Are you missing an assembly reference?

The full log contains the build command:

Tool /Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5/mcs.exe execution started with arguments: /noconfig /out:obj/Debug/mono-symbolicate.exe LocationProvider.cs SeqPointInfo.cs symbolicate.cs Logger.cs StackFrameData.cs SymbolManager.cs ../../class/Mono.Options/Mono.Options/Options.cs obj/Debug/.NETFramework,Version=v4.5.AssemblyAttribute.cs /target:exe /nostdlib /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/System.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/Mono.Cecil.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/Mono.Cecil.Mdb.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/System.Core.dll /reference:/Library/Frameworks/Mono.framework/Versions/4.4.2/lib/mono/4.5-api/mscorlib.dll

which is clearly using the system Mono.Cecil.dll, while building external/mono/mcs/tools/mono-symbolicate, which will be using the mono-bundled Cecil, not the system Cecil.

I'm not at all sure why this didn't break before, or why this particular PR is triggering an issue.

That said:

  1. Earlier today, @dellis1972 ran across a similar issue. Perhaps he has a fix?
  2. I'd like to get this underlying Cecil issue fixed before merging any other PRs, as I don't want a failing Jenkins build if we can avoid id.

@dellis1972
Copy link
Copy Markdown
Contributor

@jonpryor I'm working on the build issue. It is a result of a PR that was already merged [1], for some reason it builds ok occasionally on Jenkins... which is totally weird. I think its dependent on which system mono is installed. I have 4.8 installed and I get the same error locally.

[1] #335

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

build

@jonpryor jonpryor merged commit 6c66771 into dotnet:master Jan 4, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants