Skip to content

Add support for Round Icon#346

Closed
jamesmontemagno wants to merge 3 commits intodotnet:cycle9from
jamesmontemagno:cycle9
Closed

Add support for Round Icon#346
jamesmontemagno wants to merge 3 commits intodotnet:cycle9from
jamesmontemagno:cycle9

Conversation

@jamesmontemagno
Copy link
Copy Markdown
Member

Fixes Bugzilla #51207

@monojenkins
Copy link
Copy Markdown

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jan 4, 2017

Hi @jamesmontemagno, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

Right idea, not enough implementation. Bug #51207 is actually a duplicate of Bug #49253, and it's a subset at that.

Missing from this PR is the addition of a RoundIcon property for:

  • IntentFilterAttribute
  • PermissionAttribute
  • PermissionGroupAttribute
  • PermissionTreeAttribute
  • ApplicationAttribute
  • InstrumentationAttribute
  • ServiceAttribute
  • BroadcastReceiverAttribute
  • ContentProviderAttribute

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

build

1 similar comment
@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

build

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

@jamesmontemagno: Please create a PR that applies against master, not the cycle9 branch. We can cherry-pick to the cycle9 branch once it's on master.

(This is probably why the PR builder keeps hanging. I don't think unit test execution works on the cycle9 branch...as they didn't start working on master until November 22/a5946eb5, after cycle9 branched.)

@jonpryor
Copy link
Copy Markdown
Contributor

jonpryor commented Jan 4, 2017

This is superseded by PR #349.

@jonpryor jonpryor closed this Jan 4, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants