Skip to content

Trim assembly name extracted from IntelliSense xml file. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 2 commits into from
Sep 23, 2021
Merged

Trim assembly name extracted from IntelliSense xml file. #103

carlossanlop merged 2 commits into from
Sep 23, 2021

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Sep 23, 2021

Winforms intellisense xml files have an assembly xml item wrapped by endlines:

<?xml version="1.0"?>
<doc>
<assembly>
<name>
Microsoft.VisualBasic.Forms
</name>
</assembly>

Which caused the IntelliSenseXmlMember.Assembly string to get extracted as \nMicrosoft.VisualBasic.Forms\n, preventing the files to be matched correctly.

cc @dreddy-work

@carlossanlop carlossanlop merged commit f144bf7 into main Sep 23, 2021
@carlossanlop carlossanlop deleted the TrimAssembly branch September 23, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop