Investigate Winforms internal builds failures

[JohnTortugo]

Winforms build is failing after I updated the branch with latest Arcade updates.

Builds from the internal/release/3.1 branch are passing the validation: https://dnceng.visualstudio.com/internal/_build/results?buildId=384191&view=results

However, builds for private branches based of on internal/release/3.1 AND updated with Arcade changes by doing darc update-dependencies --channel ".NET tools - latest" -- source-repo arcade are failing:

https://dnceng.visualstudio.com/internal/_build/results?buildId=384189&view=results
https://dnceng.visualstudio.com/internal/_build/results?buildId=382989&view=results

I think this is high priority as it's might block servicing builds.

@sunandabalu @AdamYoblick @mmitche @markwilkie @riarenas

[riarenas]

can't you just disable SDL for now for these branches while it's investigated further?

Meaning yes, we need to investigate, but I don't think it blocks servicing unless something further down the pipeline fails after SDL validation.

[riarenas]

darc update-dependencies --channel ".NET tools - latest" -- source-repo arcade

This looks wrong. These builds should be updating from the ".NET 3 tools" channel

[sunandabalu]

Its the same code that is running in the both branches for SDL, the error is unrelated to Arcade updates. This looks very similar to the issue called out here - dotnet/winforms#1389

2019-10-09T19:33:30.5438687Z ##[command]"C:\windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a_temp\5eeaa1c5-1ef8-4c27-a53c-30eeb0944dd2.ps1'"
2019-10-09T19:33:31.4698544Z Processing D:\a\1\s\eng..\global.json
2019-10-09T19:33:32.8805375Z dotnet-api-docs_netcoreapp3.0 was not found in .
2019-10-09T19:33:32.8839454Z Microsoft.PowerShell.Commands.WriteErrorException: dotnet-api-docs_netcoreapp3.0 was not found in .

[JohnTortugo]

darc update-dependencies --channel ".NET tools - latest" -- source-repo arcade

This looks wrong. These builds should be updating from the ".NET 3 tools" channel

I'm using the command you suggested here: #3868 (comment) should I change now to the ".NET 3 tools" channel?

[AdamYoblick]

WPF uses these native tool versions defined in their global.json (https://github.com/dotnet/wpf/blob/e5cfb5d12e5908facb15ecc398cc9a6035a81928/global.json#L21) as well, and they also use the post-build.yml and SDL validation.

https://github.com/dotnet/wpf/blob/e5cfb5d12e5908facb15ecc398cc9a6035a81928/azure-pipelines.yml#L75

Although I clicked on their internal build, and I don't see the stages/SDL steps there, so I believe it's not really running for them. I assume the same problem would occur for them if it was.

[AdamYoblick]

But I agree with Ricardo, if we need to disable the SDL runs while this gets sorted to unblock the build, I don't see any problem with that.

[JohnTortugo]

Cool. I'll disable the validation for now then.

[riarenas]

I'm using the command you suggested here: #3868 (comment) should I change now to the ".NET 3 tools" channel?

Yes, that issue and instructions were written up before we had snapped and created that channel. All 3.x branches are set up to pull from the new channel, so the servicing tests should do the same.

[JohnTortugo]

Got same error now in a different job: https://dnceng.visualstudio.com/internal/_build/results?buildId=384371&view=results

So, this is indeed not specific to SDL validation.

PS: I'll try running the darc update-dependencies command with the channel @riarenas suggested. That might be the reason of the problem.

[JohnTortugo]

Looks like indeed the issue was caused by updating against the wrong channel. Closing.

[AdamYoblick]

@riarenas @JohnTortugo We're seeing these failures in winforms master again. I checked the darc subscriptions and it looks like our master branch is consuming builds from the ".NET Tools - Latest" channel. Should we be changing this sub to consume from ".NET 3 Tools" instead?

winforms-designer is also consuming from ".NET Tools - Latest"

[mmitche]

@AdamYoblick .NET Tools - Latest is the correct channel for master.

[AdamYoblick]

Interesting...we're still seeing errors in our master branch then. Perhaps I need to update dependencies against the latest channel again?