Allow passing AzDO build into job/execute-sdl.yml#10124
Merged
dagood merged 1 commit intodotnet:mainfrom Sep 13, 2022
Merged
Conversation
MattGal
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7611, I added a way to pass
AzDOBuildIdetc. intoeng/common/templates/job/execute-sdl.ymlso the template works for non-BAR scenarios like mine (microsoft/go). It looks like this broke in some refactor PRs, and now the Maestro/BAR-basedsetup-maestro-vars.ymlruns unconditionally.The template still has these:
So, all I had to do in this PR was make
setup-maestro-vars.ymlconditional. 🙂The change works in my build. I'm not sure if any more testing is necessary: nobody else sets these template parameters (I did some searching in
dotnet), and the change is pretty simple.@adiaaida, @garath, can you take a look, or loop in more people involved in Guardian/SDL currently?
To double check: