Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 4, 2025

Allows loc builds on both azdo & github to reuse PRs

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the ReusePr parameter to be honored for both Azure DevOps and GitHub by removing the GitHub-only guard in the OneLocBuild job template.

  • Removed the RepoType == 'gitHub' condition so reusePR applies on all repo types
  • Dedented isShouldReusePrSelected under the CreatePr block to match isUseLfLineEndingsSelected
Comments suppressed due to low confidence (2)

eng/common/core-templates/job/onelocbuild.yml:88

  • Consider updating or adding a comment above this block to explain that ReusePr now applies to all repository types, not just GitHub, to keep template docs in sync with the change.
-          ${{ if eq(parameters.RepoType, 'gitHub') }}:

eng/common/core-templates/job/onelocbuild.yml:89

  • Add or update tests to cover ReusePr behavior on Azure DevOps pipelines, ensuring that PR reuse is validated across both GitHub and Azure DevOps.
           isShouldReusePrSelected: ${{ parameters.ReusePr }}

@wtgodbe wtgodbe merged commit 8075fa6 into main Jun 4, 2025
11 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/OneLoc branch June 4, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants