Skip to content

Fix VS target hook points in Arcade SDK#16890

Merged
ViktorHofer merged 1 commit into
mainfrom
FixVSHookpointsforIBCAndManifest
May 26, 2026
Merged

Fix VS target hook points in Arcade SDK#16890
ViktorHofer merged 1 commit into
mainfrom
FixVSHookpointsforIBCAndManifest

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

Regressed with ea5fa16

Use standard hook points that are called by Build.proj (when invoking AfterSigning.proj) instead of these cutom ones.

To double check:

Regressed with ea5fa16

Use standard hook points that are called by Build.proj (when invoking AfterSigning.proj) instead of these cutom ones.
Copilot AI review requested due to automatic review settings May 26, 2026 09:43
@ViktorHofer ViktorHofer enabled auto-merge (squash) May 26, 2026 09:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression in the Arcade SDK Visual Studio insertion pipeline by switching MSBuild target hook points to ones that are actually invoked by Build.proj during the AfterSigning.proj phase.

Changes:

  • Run GenerateVisualStudioInsertionManifests before Pack (instead of before AfterPack) so it triggers in the AfterSigning.proj phase.
  • Run _BuildTrainingInputs before Pack (instead of before AfterBuild) so IBC training inputs are generated during the AfterSigning.proj phase.
Show a summary per file
File Description
src/Microsoft.DotNet.Arcade.Sdk/toolset/VisualStudio.InsertionManifests.targets Updates manifest generation to hook into Pack, ensuring it runs when AfterSigning.proj is invoked by Build.proj.
src/Microsoft.DotNet.Arcade.Sdk/toolset/VisualStudio.BuildIbcTrainingInputs.targets Updates IBC training input generation to hook into Pack, ensuring it runs in the expected AfterSigning.proj execution flow.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@ViktorHofer ViktorHofer merged commit f64bc00 into main May 26, 2026
10 of 11 checks passed
@ViktorHofer ViktorHofer deleted the FixVSHookpointsforIBCAndManifest branch May 26, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants